Lbry-desktop: History error when navigating forward from deeper in the history stack

[kauffj]

to recreate the history issue:

1. Open published
2. Click one of the links
3. Back
4. Click some other link
5. Back

[btzr-io]

~@kauffj what's the regression / issue?~

[kauffj]

Click a link that opens an http address. I see errors on the console when I do this.

[btzr-io]

@kauffj I can't recreated the issue, I tried the links from:

• wallet -> transactions
• filePage -> report link

also the buttons from settings -> help,
I can't see any errors, are sure it's related ?

[btzr-io]

What error are you getting ? :confused:

[hackrush01]

There's one more error I was getting: video

[btzr-io]

~@hackrush01 what's wrong, care to explain ?~ ^^

[btzr-io]

@hackrush01 provided this information in slack

to recreate the history issue:
1) Open published
2) Click one of the links
3) Back
4) Click some other link
5) Back

It takes you through all the previously clicked links instead of taking you to publioshed

[btzr-io]

possible fix, needs to be tested : https://github.com/lbryio/lbry-app/pull/504/commits/4e3f86521e3b7eb2da1bd586a2cd948b11d6863b ^^

[kauffj]

@btzr-io I didn't test this really, but by inspection I'm not sure this is the right solution. Do we actually need two separate arrays for back and forward? Can't I do this with just one history array and a position? Then when the user navigates forward from a position other than the top of the history stack, you delete the history past your current position.

[kauffj]

@btzr-io apologies for sending you on a wild-goose chase here, since the issue as originally reported is only happening in invites_and_rewards (I will fix it there.)

I'm going to update this ticket to just address the case laid out here: https://github.com/lbryio/lbry-app/issues/499#issuecomment-325177376

[btzr-io]

@kauffj I tried a different approach but didn't work, this was the only way...
using 2 stacks seems the more simple and clean way to do this ^^

[btzr-io]

Then when the user navigates forward from a position other than the top of the history stack, you delete the history past your current position.

Looks like a lot of work for a simple feature IMO ^^

[btzr-io]

I'll try your suggestion but it may get messy :upside_down_face:

[btzr-io]

@kauffj fixed and improved the history logic in -> https://github.com/lbryio/lbry-app/commit/f6976c3feb5a049e5071d027f520a11dbba3b4f0

[btzr-io]

@tzarebczan this was fixed and merged by @kauffj and it's already working in v0.15.0

[tzarebczan]

Closing, thanks.