Lbry-desktop: Add provision for adding multiple tags by using commas

[toktoakhil]

Is your feature request related to a problem? Please describe.
There is no option for adding multiple tags at once

Describe the solution you'd like
Add option for adding multiple tags using comma separated

option

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

[tzarebczan]

I like the suggestion, thanks @toktoakhil !!!

[toktoakhil]

My pleasure

[pranabs1ngh]

Hey, can this issue be assigned to me ?

[tzarebczan]

She's all yours! Thanks for taking a stab at it

[pranabs1ngh]

hey, is there a repo map to check, where all the components are used? If not, I only want to know, exactly where is the TagSelect (the tag entering component) used.

[seanyesmunt]

Not really. You can just search for it though
https://github.com/lbryio/lbry-desktop/search?q=%3CTagsSelect&unscoped_q=%3CTagsSelect

This has made me realize we are inconsistent with our naming. If you are up to it, could you also change these to use the same name?

[pranabs1ngh]

Okay, I will change them !!

[pranabs1ngh]

Everything done. I'm trying to commit the changes to a new branch, its showing some error:

husky > pre-commit hook failed (add --no-verify to bypass)

Should I commit, without verifying?

[seanyesmunt]

That means there are Flow errors or lint errors. There should be some explanation of the error(s) if you scroll up in your terminal.

[pranabs1ngh]

[2019-10-09 01:53:48.372] Building package heap
[2019-10-09 01:53:48.517] Loading libraries
[2019-10-09 01:53:51.361] Resolving dependencies
[2019-10-09 01:54:11.380] Failed to load recheck stats from "C:\Users\pks\AppData\Local\Temp\flow\CzCzBUserszBpkszBDocumentszBHacktoberzBlbry-desktop.recheck_stats". Reason: "File doesn't exist"
[2019-10-09 01:54:11.654] to_merge: Focused: 4, Dependents: 0, Dependencies: 6
[2019-10-09 01:54:11.654] unchanged_checked: Focused: 0, Dependents: 0, Dependencies: 0
[2019-10-09 01:54:11.654] Calculating dependencies
[2019-10-09 01:54:11.654] Merging
[2019-10-09 01:54:12.657] Merge skipped 0 of 10 modules
[2019-10-09 01:54:12.663] Done
[2019-10-09 01:54:12.663] Checked set: Focused: 4, Dependents: 0, Dependencies: 6

husky > pre-commit hook failed (add --no-verify to bypass)

[pranabs1ngh]

Its showing, that the recheck stats doesn't exist, is it that, or I missed something?

[seanyesmunt]

Is there anything above that message?

Maybe try running yarn before commiting?

[pranabs1ngh]

ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.object.get-own-property-descriptors.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.object.lookup-getter.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.object.lookup-setter.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 265 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.reflect.define-metadata.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 265 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.reflect.delete-metadata.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 267 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.reflect.get-metadata-keys.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.reflect.get-metadata.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 271 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.reflect.get-own-metadata-keys.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 266 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.reflect.get-own-metadata.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.reflect.has-metadata.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 266 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.reflect.has-own-metadata.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 263 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\es7.symbol.async-iterator.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.date.to-json.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 267 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.date.to-primitive.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 264 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.date.to-string.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 263 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.function.name.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 268 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.number.constructor.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 266 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.object.to-string.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 268 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.regexp.constructor.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.regexp.flags.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.regexp.match.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 264 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.regexp.replace.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 263 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.regexp.search.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.regexp.split.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 266 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\es6.regexp.to-string.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\web.dom.iterable.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 265 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\library\_add-to-unscopables.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 264 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\_array-species-constructor.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 261 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\core-js\modules\_new-promise-capability.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 267 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\source-map-support\browser-source-map-support.js On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 279 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\lib\__tests__\fixtures\dance_yorokobi_mai_man.bmp On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 283 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\lib\__tests__\fixtures\dance_yorokobi_mai_man.bmp.zst On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 281 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\lib\__tests__\fixtures\dance_yorokobi_mai_woman.bmp On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 285 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\lib\__tests__\fixtures\dance_yorokobi_mai_woman.bmp.zst On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 262 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\lib\__tests__\fixtures\lorem.txt On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 266 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\example ode_modules\zstd-codec\lib\__tests__\fixtures\lorem.txt.zst

above that, something like this is repeated.
already ran yarn.

[seanyesmunt]

Hm, I'm not sure what this is. You can just use --no-verify and i'll check it out on my computer

[pranabs1ngh]

On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 277 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop

This message is repeating itself for multiple core-js dependency's files.

Its repeated in the above comment too.

[seanyesmunt]

@tzarebczan Have you seen anything like that on windows?

[pranabs1ngh]

@tzarebczan Have you seen anything like that on windows?

Not sure.

[pranabs1ngh]

I think its some error on my PC. I'm commiting this. You verify it before merging.

Is this okay?

[seanyesmunt]

yes

[toktoakhil]

My Mistake Still on android , desktop and lbry.tv coma separation for adding multiple tags is not working..... FYI

[tzarebczan]

Just type the tags comma seperated and click enter or the plus next to the suggested input.

[toktoakhil]

Just type the tags comma seperated and click enter or the plus next to the suggested input.

Sorry my mistake.... Just confirmed.

Thanks