Lbry-desktop: Content has a tiny LBC fee but shown as Free in app (requires payment)

[tzarebczan]

The Issue

If the content fee is a small LBC value, like 0.01, it is shown as Free on the app even though it requires a payment. Take this instance this published item: lbry://pascalcoinwalletb21202#e5a47c49c9d8b7a58dfb719992248265adfa75a3 the fee was set to 0.01 LBC but if navigating with app, it is shown as free. When you go to purchase it, you get a pop-up that says "This will purchase [content] for free credits".

Not sure what the threshold is exactly, but we need to be more precise with our fees.

Steps to reproduce

1. Publish content with a small LBC fee value
2. Content will show up as free
   3.

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

• LBRY Daemon version:
• LBRY App version:
• LBRY Installation ID:
• Operating system:

Anything Else

Screenshots

[btzr-io]

The problem is that price is getting formated toFixed ^^

[btzr-io]

This is the current logic: 0.01999 -> 0.01 -> 0.0 -> 0 > free

[btzr-io]

I know this: 0.0019999999 looks ugly but I think the app should be more transparent about prices :stuck_out_tongue:

[btzr-io]

Alternative -> show a small button / add a settings option to display full price:

0.01 [...] -> 0.019999987

[btzr-io]

[kauffj]

I added a "<" symbol for when we are below the smallest renderable value and reduced the default precision to 2. Right now 0.01 LBC is less than a penny, so I'm not particularly concerned with more precision.

[tzarebczan]

@btzr-io -
Found an issue when downloading lbry://eight on the latest master. I like how it shows <0.01 LBC as the price, but when streaming/downloading, there is no confirmation box to purchase the content even though 0.01 LBC is charged.

There is also this change going in soon: https://github.com/lbryio/lbry/pull/835 so not sure if that fixes/affects it.

[tzarebczan]

@kauffj When they go to purchase the content, you want it also to show <0.01 LBC or show the exact price of the content in the purchase confirmation screen?

[kauffj]

Confirmation dialog should show the full price. It would also be a good idea to put the full price as a title attribute on the element when showing "<0.01" so the full price can be seen on mouseover.

[kauffj]

Fixed in https://github.com/lbryio/lbry-app/commit/c03c0de0a2b7c3b12b6041f7a851997f0e4229c2