Keepassxc-browser: Translations update, please

[Stephan-P]

Expected Behavior

I've spend quite some work updating the Dutch translation in TransiFex. To check things, I've downloaded the messages.json and replaced the original file in my local profile.
I double checked and yes all messages in there are in Dutch language.
With messages.json locally updated, I would have expected all of KeePassXC-browser to show up in Dutch language.

Current Behavior

messages.json locally updated. Many messages in the KeePassXC-browser extension remain in English language.

Possible Solution

I suspect that some work needs to be done in updating string references

Steps to Reproduce (for bugs)

1. Login to TransiFex
2. Go to the Dutch language (100% translated)
3. Download messages.json
4. Replace messages.json in your local profile (\users\username\app data\local\vivaldi\default\extensions...

Debug info

KeePassXC - 2.4.3
KeePassXC-Browser - 1.5.0
Operating system: Win32 (Incorrect! Should be Win64)
Browser: Chrome/Chromium 77.0.3865.93 (Partly incorrect. Should be Vivaldi 2.9.1675.11 (Officiële build) (64-bits))

[varjolintu]

If everything is in English, it's probably because of you browser locale. Plus, if you update any of the translation files, you'll have to reload the local extension.

[Stephan-P]

My locale is in Dutch; for the OS, as well as my browser Vivaldi

Stephan Paternotte

[varjolintu]

Make sure you are following the correct process of testing translations with Vivaldi. This is not a bug in the extension.

[Stephan-P]

Thank you for your assistance.
What's the correct process of using the keepassxc-browser in Vivaldi browser?

Stephan Paternotte

[varjolintu]

I have no information how Vivaldi browser handles the locales and translation files for extensions, but AFAIK it shouldn't differ from Chrome/Chromium.

[Matthaiks]

messages.json files at Transifex are outdated. Check out this report: WinMerge File Compare Report.zip

[varjolintu]

I will update it soon. There's still one PR that has more changes to the translation file, and it hasn't been merged yet. So, waiting for that.

[Stephan-P]

Meanwhile v1.5.3 of KeePassXC_browser has been released and I'm pretty sure that the Dutch translation in Transifex is kept up to date. Still, the KeePassXC-Browser extension remains untranslated English in my Vivaldi browser in Dutch language. The same counts for the Edge (Chromium) browser in Dutch language: KeepassXC Browser is in English.

Info from Vivaldi 2.9.1735.3 (Officiële build) (64-bits):
KeePassXC - 2.5.1
KeePassXC-Browser - 1.5.3
Operating system: Win32 (incorrect. must be Win64)
Browser: Chrome/Chromium 79.0.3945.45

Info from Edge Dev 80.0.334.4 (Officiële build) dev (64-bits):
KeePassXC - 2.5.1
KeePassXC-Browser - 1.5.3
Operating system: Win32 (incorrect. must be Win64)
Browser: Chrome/Chromium 80.0.3965.0

[varjolintu]

@Stephan-P And everything is fine with Firefox and Chrome/Chromium?

[Stephan-P]

I don't have these browsers installed anywhere. Could give it a brief experiment.

[Stephan-P]

I've just installed Chrome on my laptop, switched its UI to Dutch and installed the KeePassXC-browser extension. Chrome is in Dutch, the extension is in English. Also after a restart of Chrome.
I'm now deleting Google Chrome from my laptop again.

[Stephan-P]

I'd like to add that Edge (Chromium) Stable too does not display KeePassXC-browser in the correct locale, Dutch in my case.

Info from Microsoft Edge 79.0.309.68 (Officiële build) (64-bits)
KeePassXC - 2.5.3
KeePassXC-Browser - 1.5.4
Operating system: Win32 (incorrect. must be Win64)
Browser: Chrome/Chromium 79.0.3945.130

Info from Vivaldi | 2.11.1789.3 (Officiële build) (64-bits)
KeePassXC - 2.5.3
KeePassXC-Browser - 1.5.4
Operating system: Win32 (incorrect. must be Win64)
Browser: Chrome/Chromium 79.0.3945.118

[varjolintu]

When I tested the Edge support, for some reason Edge was installed in a wrong language (spanish), and the locale worked just fine.

I haven't heard about these issues from anyone else, and I cannot reproduce them. Can you verify this happens on other computers too?

[Stephan-P]

On my PC's the installation of Edge was in in English language, but soon enough I changed that into Dutch language for the UI.
On my PC's, the OS is Dutch and most of my apps are in Dutch language, so are my Vivaldi's and Edge's.

But I've got a pleasant surprise for you.
Remember you asked me to also test Firefox? Well I just did.
I downloaded and installed the Dutch language version of Firefox and added the KPXC-B add-on.
Lo and behold: finally KPXC-B showed up in Dutch language!

So, the issue seems to ly between KPXC-B and the Chromium-based browsers.
Possibly the locale detection is failing for these browsers?

Edit: typo corrected

[Stephan-P]

Is there anything I can do, here on my Dutch browsers, to debug this issue?
With some guidelines from you I might give it a trie.

[Stephan-P]

Or - if you say that Spanish is working alright - could it be that the Dutch language is not (yet) included in KeePassXC-Browser v1.5.4?

[varjolintu]

nl_NL locale is included in the extension.

I'm quite sure this issue has something to do with Chromium-based browsers and not the extension itself. Do you have any other extensions that have the same problem in the same browser?

[Stephan-P]

Nope, KPXC-B is the only one.

But I've got another clue:
I decided to change the UI language for Edge into Spanish. After the restart KPXC-B showed up in Spanish. Same for French.
So, the issue seems to narrow down to the Dutch language.
I don't know how these browsers present their locale to the extension, but could it be the distinction or a mismatch between nl, NL, nl-NL, nl-BE, ....?

Edit: the same positive effect when changing Vivaldi into French UI

[varjolintu]

That actually could be the issue, because according to this list, the locale should be nl: https://developer.chrome.com/webstore/i18n#localeTable

And because translations are received from Transifex, I think the renaming must be done there.

[varjolintu]

Seems Transifex has both nl and nl-NL for Dutch (Netherlands). I added the nl, but I'm unsure if the same locale can be used for both. I bet you're the professional one here :)

[Stephan-P]

You've added a new branch nl next to the existing nl-NL.
I can't seem to find a way to copy the existing nl-NL translation to the nl branch.
(I am able to download, but the option to upload to 'nl' does not appear.)
Can you do that easily?

About nl, nl-NL, nl-BE, nl-FY:
nl is the general Dutch language
If one is interested in making distinction between Dutch language from The Netherlands or Dutch language from Belgium, then nl-NL and nl-BE are the respective dialects. There's not much point in this because both countries use a common dictionary and grammar rules.
In the Netherlands we have one official sub language Frysian (nl-FY), but this is not supported from chrome.

So, I guess we can do with one single Dutch language: nl.
You could either rename the old nl-NL into nl, or copy the contents from nl-NL into the new nl and remove the old nl-NL.
Is that something you can do more easily than I can?

[Stephan-P]

Ha!
I managed to add myself as translator and upload the complete translation I had just downloaded from nl-NL.
It's up to you what to do next:

• remove nl-NL (with its translators)
• Remove nl and rename nl-NL into nl (keeping its translators)

[varjolintu]

EDIT: I'll delete the nl-NL locale.

I couldn't find an option that would allow me to rename an existing translation.

[Stephan-P]

You may want to check the other languages that use the extended coding:

• zh-CN
• zh-TW
• hr-HR
• pt-PT
• pt-BR

my guess is that Croatian, like Dutch should be a short code 'hr'
Not sure about Chinese and Portugese.

[varjolintu]

Chinese and Portugese are correct. Croatian is not. So we need to change that one too.

[Stephan-P]

I may be speaking ahead of time, but since you closed this issue I was interested to see the new "nl" language getting in place.
But https://github.com/keepassxreboot/keepassxc-browser/tree/develop/keepassxc-browser/_locales shows the folder nl-NL from 11 months ago instead of the folder "nl".
I hope that this is still on your to-do list before the new relese

[varjolintu]

@Stephan-P The translations are downloaded from Transifex when making a new release, so nl is there. The repository is just not up-to-date.

[Matthaiks]

BTW, some translated strings in KeePassXC 2.5.3 are in English only. For instance,

KeePassXC-Browser is needed for the browser integration to work.
Download it for %1 and %2. %3

[varjolintu]

@Matthaiks That means someone hasn't translated them for your language via Transifex.

[Matthaiks]

@varjolintu But those strings are translated and that's the problem. I've copied that example above from the fully translated file.

[Stephan-P]

@Matthaiks if you're talking about the current version of kpxc-browser, then the Dutch translation is not yet in place. This is expected with the next release. Everything is ready place in for this.
@varjolintu if this particular string Matthaiks is referring to should be left untranslated, then I could fix that. Just let me know.

[Matthaiks]

I'm talking about KeePassXC 2.5.3. It seems that all languages are affected. Some strings in KeePassXC are just hard-coded or something.

[varjolintu]

What are those strings exactly?

[Stephan-P]

There may be a confusion here. I suspect that Matthaiks is talking about a text string in KPXC, not KPXC-Browser. Wrong Github tree.

[Matthaiks]

@Stephan-P Yes, sorry for hijacking your thread.

@varjolintu More strings:

From 'Encryption Settings'

AES: 256-bit
Twofish: 256-bit
ChaCha20: 256-bit

Argon2 (KDBX 4 – recommended)
AES-KDF (KDBX 4)
AES-KDF (KDBX 3.1)

From 'Secret Service Integration'

File Name
Group
Application
Manage
None
Edit database settings
Lock database
Unlock to show
Unlock database to show more information

[varjolintu]

@Matthaiks Those translations are not related to the extension at all. You are referring to the main application translations.

[Stephan-P]

Best to report them HERE