Keepassxc-browser: Don't retrieve credentials when no login fields are found

[phoerious]

Expected Behavior

The extension should not ask KeePassXC to provide credentials when there are no login fields on a page. Additional heuristics to determine if a user is already logged in are welcome as well.

Current Behavior

KeePassXC-Browsers tries to retrieve credentials every time when "Automatically retrieve credentials" is enabled, even if I'm already logged in.

Debug info

KeePassXC - Version 2.3.3-snapshot
Build Type: Snapshot
Revision: b02bd59

Libraries:

• Qt 5.10.1
• libgcrypt 1.8.2

Operating system: Arch Linux
CPU architecture: x86_64
Kernel: linux 4.16.7-1-ARCH

Enabled extensions:

• Auto-Type
• Browser Integration
• SSH Agent
• YubiKey

[ramenchef]

To add on top of this, if you also have "Automatically fill-in single credentials entry." it seems to fill in the username into every search bar it finds on matching webpages. In keepass, if you check "remember choice" and then click deny, it ignores the setting and still asks for permission to retrieve the credentials.

[varjolintu]

I agree with you. All these changes are very welcome. I'll make them to the next version.

[sxe]

I absolutely agree and I would also call this a bug cause the behaviour changed. It never happened to me before. It started occuring after i update to keepassxc 2.3.3 (from 2.3.1).

Happy to provide more info if necessary.

Cheers

[varjolintu]

@sxe Probably this happens even if you try to downgrade back to 2.3.1 because I'm quite certain that the change is happening in the extension side.

[ArchangeGabriel]

Yeah, I think that 1.1 changed that behaviour. Now I get asked as soon as there is any input field on a website for which I have credentials, and this is very annoying…

[phoerious]

Please update to 1.1.1.

[ArchangeGabriel]

I did, the issue remains.

[varjolintu]

I'm going to fix this ASAP.

[olifre]

Could we also get another release incorporating that fix?
The current 1.1 and 1.1.1 are really almost unusable due to this, especially when notifications are enabled for each query in KeepassXC, which now are shown on almost every page load.

[phoerious]

We will release a patch soon. In the meantime, you can turn off automatic retrieval of credentials in the settings.

[jtl999]

I'm still getting some slowdown with KeePassXC 2.3.3 and KeePassXC-Browser 1.1.2 on Firefox 59.0.3 under Linux despite removing and reinstalling the extensions and disabling the automatic retrieval of credentials.

[phoerious]

Slowdown may be related to #1765. Could you check if you have multiple keepassxc_proxy processes running?

[jtl999]

No

[jtl@jtl-desktop ~]$ ps -ef |grep keepassxc |grep -v grep
jtl       1436  1074  0 09:29 ?        00:00:19 keepassxc
jtl      13800 13641  0 13:01 ?        00:00:00 /usr/bin/keepassxc-proxy /home/jtl/.mozilla/native-messaging-hosts/org.keepassxc.keepassxc_browser.json [email protected]

And I custom compiled KeePassXC to disable unneeded options.

KeePassXC - Version 2.3.3
Revision: 0a155d8

Libraries:
- Qt 5.10.1
- libgcrypt 1.8.2

Operating system: void
CPU architecture: x86_64
Kernel: linux 4.15.15_2

Enabled extensions:
- Browser Integration

[jtl999]

Quick five minute test of 1.1.3 this morning. Havn't had Firefox freeze at all despite "Automatically retrieve credentials" turned on.

I will update if I have further problems.