Julia-vscode: v0.14.x release planning
All the stuff we did deserves a better version than a patch release :) Also, lets leave the unlucky 13 behind us.
davidanthoff
All 28 comments
@ZacLN I looked through all the items in https://github.com/orgs/julia-vscode/projects/3 that are assigned to me, and I think if everything in progress right now is merged I have no other things on my end that should go into the next beta release. Could you look through your items? I think there are many that can just be moved to the next release (i.e. removed from the project, and then assigned to the next milestone in that particular repo).
davidanthoff
on 27 Jan 2020
OK, I've cleared out the formatting issues. I'll have a look soon but they're non-critical. It would be good if you could check https://github.com/julia-vscode/StaticLint.jl/issues/68.
800 and #867 are the same (the environment of a package doesn't contain the package itself) - not immediately clear how to handle this but I'll have a think tonight.
ZacLN
on 27 Jan 2020
I'd be ok that we push #800 and #867 to v0.14.1. That has never worked, so it is not a regression, and I think it would be better to get the current set of fixes out and get some telemetry on that.
davidanthoff
on 27 Jan 2020
davidanthoff
on 28 Jan 2020
@ZacLN I think most of the issues are stuff for you to look into, a fair number of things from crash reporting etc. Most of them seem like genuine bugs, so we probably shouldn't move them to a later release? Your call, really!
davidanthoff
on 5 Feb 2020
@ZacLN Once https://github.com/julia-vscode/SymbolServer.jl/pull/92 is merged, are we ready for a release candidate? I think we should only cut one if we don't have anything from our end that we currently want to include in the release, i.e. once we have a RC we would only add fixes in response to bug reports.
More broadly, once 0.14.0 is out, I think we should do another bug fix release 0.14.1 (or more) before we start making bigger changes again. Does that sound good?
davidanthoff
on 10 Feb 2020
Yep sounds good
ZacLN
on 10 Feb 2020
I might have one more fix. I think the LS crashes if one hasn't created any env. I'll try to fix that, this will hit beginners :)
davidanthoff
on 11 Feb 2020
We have a first release candidate: https://github.com/julia-vscode/julia-vscode/releases/tag/v0.14.0-rc.1.
davidanthoff
on 11 Feb 2020
@ZacLN should I release to the marketplace first thing tomorrow morning? My sense is that what we have right now is already way better than the currently shipping version. Also, we aren't really getting many beta testers right now, so I think we should just ship to everyone to get more crash reports.
Could you open a PR against CHANGELOG.md with the things you added? I would merge that and then tag things as they are now.
davidanthoff
on 12 Feb 2020
I didn't know we had a changelog (and I love the entry for 13.1 :smiley:).
ZacLN
on 12 Feb 2020
There are many of those (0.11.1, 0.9.1) because I normally forget every time ;) The CHANGELOG that is there at the moment when we publish is shown in the marketplace, so it is kind of user facing.
davidanthoff
on 12 Feb 2020
@ZacLN The only open issue on the milestone right now is https://github.com/julia-vscode/julia-vscode/issues/994. I assume we are done with that for now? Should I create a new release candidate?
davidanthoff
on 16 Feb 2020
Yes, done with that for the moment - let's release!
ZacLN
on 17 Feb 2020
davidanthoff
on 17 Feb 2020
If we get 24 hours without massive new crash reports, I'll release to the marketplace.
davidanthoff
on 17 Feb 2020
@ZacLN, so https://github.com/julia-vscode/LanguageServer.jl/issues/535 indicates that our doc handling is still buggy, and after having looked through the code I'm pretty sure that it right now is a) too complex with too many places that can modify the doc list and doc content, and b) there are some bugs in that that I identified.
https://github.com/julia-vscode/LanguageServer.jl/pull/537 and https://github.com/julia-vscode/StaticLint.jl/pull/99 are an attempt to get a cleaner separation in terms of layering. They are big changes, but I think if we want to fix these sorts of problems for good, we'll just have to do something like that... Should we do a call on this?
davidanthoff
on 18 Feb 2020
There's a lot to cover in that so a call is probably best
ZacLN
on 18 Feb 2020
Are we good to go on this now?
ZacLN
on 26 Feb 2020
There is one more PR on https://github.com/orgs/julia-vscode/projects/3 that you need to merge, and then I can release a new insider build. I'd say that if that survives 24 hours without horrible bugs, we push it out as a normal release?
So far things are looking good, no crash reports at all for the latest insider build :) But the latest PRs you merged are not included in that, so we should make sure we have another 24 hours with a newer insider build before we push out to everyone.
davidanthoff
on 27 Feb 2020
I guess another question is whether we should just decide to ship a build from v0.14.x that we know has some corner bugs still... But I think even what we have now is probably more stable than the 0.13 that is shipped, right?
Maybe we should merge https://github.com/julia-vscode/LanguageServer.jl/pull/568 and https://github.com/julia-vscode/SymbolServer.jl/pull/107, push these out to the insider channel, wait a day, and unless there is some widespread problem, ship that version to everyone? And then get back and try to fix the UTF-8 issue in a follow up release in the 0.14.x series?
davidanthoff
on 29 Feb 2020
Yep I think shipping now is the best approach, it's definitely more stable.
ZacLN
on 29 Feb 2020
So here are our crash statistics since we published 0.14: 319 users are using it right now, 15 have reported at least one crash. That compares to 1.2k users for 0.13 with 87 users with a crash. So definitely an improvement in terms of how many users are affected :)
davidanthoff
on 2 Mar 2020
@ZacLN I think once we have merged https://github.com/julia-vscode/LanguageServer.jl/pull/577, I will push a build to the insider channel. Hopefully we'll get some crash reports from there that will allow us to figure out what is going on in https://github.com/julia-vscode/LanguageServer.jl/issues/571.
davidanthoff
on 4 Mar 2020
Super, approved
ZacLN
on 4 Mar 2020
So here are our crash statistics since we published 0.14: 319 users are using it right now, 15 have reported at least one crash. That compares to 1.2k users for 0.13 with 87 users with a crash. So definitely an improvement in terms of how many users are affected :)
Is there a way to automatically report crashes from other editors as well?
gdkrmr
on 6 Mar 2020
You mean, non VS Code editors? They would just have to add the kind of crash reporting and telemetry that we added to the VS Code extension.
davidanthoff
on 6 Mar 2020
I would say that once https://github.com/julia-vscode/LanguageServer.jl/pull/584 is merged I'll push out a new build to insiders, and if that passes the 24 hours without major new problems I'll push it out to everyone.
In general I'm trying to push out more incremental updates more quickly to everybody if it makes it without problems through the insider group.
davidanthoff
on 8 Mar 2020
Related issues
gdkrmr
路
36Comments
davidanthoff
路
25Comments
rapus95
路
62Comments
davidanthoff
路
27Comments
scls19fr
路
40Comments
Most helpful comment
So here are our crash statistics since we published 0.14: 319 users are using it right now, 15 have reported at least one crash. That compares to 1.2k users for 0.13 with 87 users with a crash. So definitely an improvement in terms of how many users are affected :)