Julia-vscode: v0.11.0 release planning

[davidanthoff]

So far, not much of a plan. This is just to discuss the v0.11 release.

I would really love to finally no longer load user packages into the LS process, but it might be a bit of a lift, and I'm not 100% sure how much time I'll have in the short run...

[ZacLN]

Hi- I may have seemed quiet but I've been busying away on v0.7 stuff.

General ideas:

• target v0.7
• bump LS version
• integrate StaticLint (better accuracy)
• integrate femtocleaner/Deprecations.jl
• I'm currently working on 'graceful failure' for CSTParser to which should improve parse error message + provide auto fixes. (This requires a bit of a rewrite of CSTParser)
• cache modules

[davidanthoff]

Are we going to have a version that targets both 0.6 and 0.7 at the same time? Unclear to me how complicated that would be...

[ZacLN]

I'd push for v0.7 only

[ZacLN]

Quick update:

• Tokenize is updated
• CSTParser is updated for v0.7, parse failure recovery seems to be working
• StaticLint working on v0.7
• I've updated the LanguageServer protocol and made v0.7 fixes-now need to get everything working
• need to integrate Deprecations.jl into LanguageServer

[davidanthoff]

Oh wow, that is fantastic!

[ZacLN]

@davidanthoff , do you think the new package system means we can move away from including our own package versions in the julia-vscode install?

[davidanthoff]

I think it would still be easier to just include them as submodules, less download time, and no install step. But I might be wrong, I'll have to investigate a bit more.

[lewisl]

Any thoughts on a preliminary release for 0.7? I think it might be a little bit hard to support both as many things have changed. You might need to keep around a renamed old version for 0.6 and earlier and some people will not quickly migrate as there is some non-trivial work to update code to 0.7 and 1.0. Or perhaps easier--make a new name for the 0.7+ version...

[davidanthoff]

I think the only realistic thing is that the next release will support 0.7/1.0 only, I don't think we have the man power to support multiple versions at the same time... I don't want to create multiple versions of the extension. I wonder: is there support in VS Code to pin an extension, i.e. force a certain version to be used?

[lewisl]

My view is that this is reasonable for both manpower reasons and because Julia is not going to fork the way Python did. Some folks may legitimately need to wait for crucial packages, but it won’t be a decade as it was for Python (because that process and decision were mismanaged). It is a bit more work than I enjoyed to migrate code—especially if you are working with text. But, I am not so skilled and it was mostly just slogging, looking at the error/deprecation messages, studying the new API/function, slapping side of head, and doing what I was told. It’s going to be a one-time thing. My sense is that people will want to move up to 0.7/1.0, even if grumbling a little. The performance gains alone are worth it (Python 3.x was slower for years…) and the functional gains are there should you be doing things where you can use them.

From: David Anthoff [e-mail]
Reply-To: JuliaEditorSupport/julia-vscode [e-mail]
Date: Tuesday, August 28, 2018 at 1:25 AM
To: JuliaEditorSupport/julia-vscode [e-mail]
Cc: Lewis Levin [e-mail], Comment [e-mail]
Subject: Re: [JuliaEditorSupport/julia-vscode] v0.11.0 release planning (#493)

I think the only realistic thing is that the next release will support 0.7/1.0 only, I don't think we have the man power to support multiple versions at the same time... I don't want to create multiple versions of the extension. I wonder: is there support in VS Code to pin an extension, i.e. force a certain version to be used?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/JuliaEditorSupport/julia-vscode/issues/493#issuecomment-416455364, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABGLLY1wrh4Z_76TvsW7LAmoZhbkOkANks5uVNRMgaJpZM4T3Oo0.

[ufechner7]

After closing many 0.7/1.0 issues, what is missing to make a new release?

[davidanthoff]

https://github.com/JuliaEditorSupport/julia-vscode/milestone/13 shows the current plan. We might also cut some things there...

We also need to go through https://github.com/JuliaEditorSupport/LanguageServer.jl/milestone/15 and see what still applies and what doesn't...

[CarloLucibello]

hi, vscode support for julia >=0.7 has become quite urgent to me and likely to many other people. Since master already addresses this, can we have a 0.11 release right now and postpone the other milestones to 0.12?

[ianfiske]

@CarloLucibello Another option if you can't wait for the official release is to follow the directions on https://github.com/JuliaEditorSupport/julia-vscode/wiki/Updating-to-the-lastest-julia-vscode to install from the latest on master.

[CarloLucibello]

Guys, I know I can update to master but I'd like to keep things clean.

Things are moving slowly here and I don't see what's the point in delaying official 1.0 support while waiting for much less important extra features to be added. Tagging is just a few clicks away and comes for free, let's do it!

[davidanthoff]

@ZacLN I think here are the next steps:

• You merge https://github.com/ZacLN/StaticLint.jl/pull/13
• I went through all the LS issues, and this is now up-to-date. Can you look through these and move anything you don't want to fix to the backlog?
• Same for the issues in this repo, can you look through this and move anything to the backlog we can defer to a later release?

And then we need to test more... I'm not sure whether we are actually picking up the right things for the cache for user packages right now or not...

[davidanthoff]

@CarloLucibello you can pretty easily install an alpha release from here now. But things are not yet ready to be released, there are quite a number of things that just don't work, or don't work properly.

[ZacLN]

I've cleaned up some bugs in LanguageServer and StaticLint that crept in during your (impressive) blitz yesterday. Issues are clear so we should bump submodules and make a new alpha/beta release

[davidanthoff]

https://github.com/JuliaEditorSupport/julia-vscode/releases/tag/v0.11.0-alpha.9

[davidanthoff]

Alright, nothing left on the milestones! I just moved everything to the backlog (one way to solve things).

I would suggest we let people play with the current alpha 9 for a day, and then cut a beta.1 release with a big announcement on discourse. Then we give it a week, and assuming nothing major comes up, we start to create release candidates mid-next week and then release. Does that sound good?

I think there is still a lot we need to sort out with how the cache in the SymbolServer.jl is generated, but lets do that for the next release.

[davidanthoff]

https://discourse.julialang.org/t/vs-code-extension-v0-11-0-beta-release/17541

[davidanthoff]

@ZacLN I just went through all the issues on the milestone, and also added issues for everything that I found on the telemetry error reporting for v0.11.0-beta.2 (which was quite a lot).

There are a few things where I might be able to help, but my sense is most of this is somewhere deep in the guts of LS/CSTParser etc... I've got some time over the winter break, so maybe we could try to push things? And maybe even release a version before the end of the year? Although that might be ambitious, with our new, quite long bug list...

[davidanthoff]

Another option would be to very aggressively move bugs to the v0.11.1 milestone (I just created that)... Just so that we can release a julia 1.0 compat version to the marketplace rather sooner than later. I looked through the current milestone, and I don't think that would be the end of the world (assuming we merge some of the pending PRs first). @ZacLN maybe that is best for you to decide, depending on how much time you have available?

[ZacLN]

I also have some time over the holidays so I'm going to dive into the bugs. There are a few that I think are unfixable from the current info, I'll shift those to the 11.1 milestone. I think we should aim for a proper release by the new year, it's been a bit too long...

[davidanthoff]

I moved a couple more issues to the v0.11.1 milestone. So now the open issues are
https://github.com/JuliaEditorSupport/LanguageServer.jl/issues/292,
https://github.com/JuliaEditorSupport/LanguageServer.jl/issues/314 and
https://github.com/JuliaEditorSupport/julia-vscode/issues/637. @ZacLN should we also move them to a later milestone? And then release a release candidate?

[ZacLN]

Yep let's do it

[davidanthoff]

Here is a first release candidate:

https://github.com/JuliaEditorSupport/julia-vscode/releases/tag/v0.11.0-rc.1

[davidanthoff]

Second release candidate:

https://github.com/JuliaEditorSupport/julia-vscode/releases/tag/v0.11.0-rc.2

[davidanthoff]

@ZacLN Should we release it to the marketplace as is? There doesn't seem to be a showstopper catastrophic bug, so I'd vote for getting it out.

[ZacLN]

Yep lets do it

[davidanthoff]

Alright, it is out and on the marketplace :) Hurray!

I actually published a v0.11.0, and then right after that a v0.11.1. The latter only has an updated CHANGELOG. Of course I remembered that EXACTLY after I had published v0.11.0 ;)