Jtapplecalendar: reloadData unowned reference crash

[hennykat]

JTAppleCalendar Version: 7.1.3
Swift 4 / XCode 9.1

Crash in: UserInteractionFunctions.swift > reloadData(withAnchor:completionHandler:)
Log: Fatal error: Attempted to read an unowned reference but the object was already deallocated

Steps to reproduce:

1. Calendar is created (User navigates to calendar UI where CalendarView nib containing JTAppleCalendar is loaded into view)
2. Calendar is destroyed (User triggers hard UI refresh, removing CalendarView nib from view and deallocating)

*Not consistently reproducible, but has been seen 3 times in the past few days
Presumably, this is occurring because the calendar is destroyed before the calendar reload completion is executed.

[patchthecode]

hmm. this is bad. Do you have a sample application that contains this issue?
I would really like to get my hands on that to fix immediately.
I will try to reproduce your steps.

[hennykat]

Unfortunately I don't have a sample application. I can try to make one if you need

[patchthecode]

Yea. i'm caught up on another project. I can take a look at this at the least in another 4-5 days.
But if you provide a sample app with it, i can look at it a lot sooner.

[patchthecode]

But i already see a fix.
it should be set to weak instead of unowned.
I did not foresee your use-case. Weak, will make it nillable and thus it would not crash if its no longer available.

I will test the fix today if you provide a sample.

[hennykat]

Okay, I will make a sample and get back to you

[hennykat]

I can't seem to make a sample application where this is consistently reproducible. Not sure where to go from here.

[patchthecode]

@hennykat its ok, just send the sample app.
I will look through it and judge. I already suspect where it is, your sample app, will help.
You can zip it and drop it in this chat box, or send to [email protected]

[hennykat]

Sorry, I already put it up by the time I read this. Hope this is ok: https://github.com/hennykat/CalendarSample

[patchthecode]

ok, i'll check it out over after work.

[patchthecode]

replace this in your Podfile and do a pod install

pod 'JTAppleCalendar', :git => 'https://github.com/patchthecode/JTAppleCalendar.git', :branch => 'master'

Let me know if your bug is resolved

[hennykat]

The bug seems to be resolved! I have yet to see the crash happen again.
Will this change be in the 7.1.5 release?

[patchthecode]

yes, it will be in version 7.1.5 once i release it.
i'll leave this issue open until release. Then i will close

[JettF]

I ran into this bug as well. Thanks for fixing it. I am actively developing a feature right now, so relying on Master is fine. Looking forward to the 7.1.5 release!

[patchthecode]

7.1.5 released