Joplin: Goto Anything: Keyboard selection starts at bottom of visible results

[thororm]

Environment

Joplin version: v1.0.201
Platform: Windows
OS specifics: 10

Steps to reproduce

1. Open Goto Anything search
2. Enter a search term where the number of results triggers the scrollbar
3. Press the arrow up or down key
4. The selection will be at the bottom of the result list

Describe what you expected to happen

That the first element of the results is highlighted/selected.
The same as the behavior with search terms that do not trigger the scrollbar.

[naviji]

Can't reproduce.

[Rolograaf]

I can reproduce since I reported this bug on the forum https://discourse.joplinapp.org/t/strange-goto-anything-behavior/8139/3

[naviji]

Okay, can you give me some more details?

For example, in this issue, it says that the up or down arrow keys are causing the problem.
In the forum, the "enter" key is causing the problem.

Also, does the selection always go to the 16th entry (last?) or does it change?
Try adding what you searched for in the note body. Does it change the selection position?

[ylc395]

I have located the problem. selectedItemId is reused between two calls of updateList. I will submit a PR to fix this.