Jetpack: Jetpack_Data deprecation issues

[jeherve]

Note: this may very soon be addressed in a new release of the WooCommerce Shipping & Tax plugin

In #18812, we got rid of the deprecated Jetpack_Data class. This is causing issues for plugins that still rely on the class, such as WooCommerce Shipping & Tax:
https://github.com/Automattic/woocommerce-services/blob/8d05b1f2d23483d142fe799e537664b5e6acbec5/classes/class-wc-connect-nux.php#L315

The problem is, we were not outputting a big deprecation notice, so that deprecation probably flew under the radar for all these years.

---

Potential solutions:

• A WooCommerce Shipping & Tax to get rid of the deprecated code https://github.com/Automattic/woocommerce-services/pull/2346
• A Jetpack point release to bring the class back.
• Both?

[jeherve]

Reports:

• p1614700936209600-slack-C3GP81E05
• p1614699388293500-slack-C3NCP7ZJ6
• p1614703679083300-slack-CU6SYV31A
• 21495452-hc
• 28128569-hc

[tbradsha]

25409975-hc

[happychait]

19473560-hc

[carladoria]

3786924-hc

[rwaynick]

Adding 3787204-zen and 3786946-zen so that I can follow-up once it's resolved.

[wpericam]

28131980-hc

[jessLundie]

28132279-hc -> 3787505-zen

[fevered]

3787205-zen

[jessLundie]

26706439-hc -> 3787549-zen

[jeherve]

The problem has now been fixed on Atomic sites. For folks running the self-hosted version of Jetpack and WooCommerce Shipping & Tax, the WooCommerce Shipping & Tax plugin will be updated soon to fix this issue.

[sbathompson-he]

3787186-zen & 3786936-zen

[tbradsha]

@jeherve I'm still seeing this on my end despite clearing my cache. Anything else that needs to be done?

[desnum]

Another case here 28133794-hc where the issue still persists on an Atomic site

[ash1eygrace]

The issue is persisting on an AT site after the temporary fix above. 28132059-hc > 3787722-zen

I've updated my customer that this has been fixed.

[happychait]

I still see the issue on my customer's site too.

[CompChris]

11417480-hc Atomic problem here as well

[desnum]

Another case: 17852724-hc

[dani-elo]

Adding these tickets to notify the users when the issue is fixed.

3787787-zen --> The issue is persisting on an AT site after the temporary fix above.
3787800-zen --> Self hosted

Already notified by @dani-elo

[frosso]

WooCommerce Shipping & Tax version 1.25.8 has been released with a fix.

[danjjohnson]

We have a report in 3787724-zen that after updating to v1.25.8, the option for "No, I will enter prices exclusive of tax" remains grayed-out, and the following errors are shown:

The plugin generated 263 characters of unexpected output during activation. If you notice “headers already sent” messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.

Warning: Use of undefined constant JETPACK_MASTER_USER - assumed 'JETPACK_MASTER_USER' (this will throw an Error in a future version of PHP) in /wp-content/plugins/woocommerce-services/classes/class-wc-connect-nux.php on line 305

Warning: Cannot modify header information - headers already sent by (output started at /wp-content/plugins/woocommerce-services/classes/class-wc-connect-nux.php:305) in /wp-includes/functions.php on line 6360

Warning: Use of undefined constant JETPACK_MASTER_USER - assumed 'JETPACK_MASTER_USER' (this will throw an Error in a future version of PHP) in /wp-content/plugins/woocommerce-services/classes/class-wc-connect-nux.php on line 305

Warning: Cannot modify header information - headers already sent by (output started at /wp-content/plugins/woocommerce-services/classes/class-wc-connect-nux.php:305) in /wp-admin/includes/misc.php on line 1310

Warning: Cannot modify header information - headers already sent by (output started at /wp-content/plugins/woocommerce-services/classes/class-wc-connect-nux.php:305) in /wp-includes/pluggable.php on line 1296

Is this related to the same issue?

[jeherve]

@danjjohnson I believe this is tracked here:
185-gh-Automattic/woocommerce-shipping-issues

I'll close this issue.