Jetpack: Handle Akismet/Privacy banner properly within Jetpack dashboard

Created on 1 Nov 2018  Â·  7Comments  Â·  Source: Automattic/jetpack

Steps to reproduce the issue

On a fresh WP site with Jetpack and Akismet active, you will see a banner coming from Akismet with interacts very poorly with Jetpack's dashboard:

screen_shot_2018-11-01_at_12_38_34_pm

What I expected

We should either handle and integrate this banner properly within the context of the Jetpack Dashboard, or else suppress it completely on this view.

Admin Page [Pri] Normal [Status] Needs Design [Type] Bug

All 7 comments

@procifer What do you recommend we do here? I located that code in this file /wp-content/mu-plugins/akismet-3.0/views/notice.php#135 but have no idea how it can be integrated into the JP dashboard more neatly. Any tips would be welcome — thanks in advance!

We handle some other banners within the context of the Jetpack dashboard by transforming them into something that's rendered within the main content area. I'd hope we could just do something similar, but if not then it would be an improvement to just hide this specific banner on this view.

The Akismet setup banner on the /wp-admin dashboard needs to be responsive as well. Currently on mobile view, it can be seen to be cropped out.

screenshot 2018-11-08 at 14 38 53
screenshot 2018-11-08 at 14 39 23

@arunsathiya This is more of an Akismet issue and not something we should fix in Jetpack since we want the banner to be responsive even if you only use Akismet, and not Jetpack.

I would recommend reporting the issue on +akismetp2.

We handle some other banners within the context of the Jetpack dashboard by transforming them into something that's rendered within the main content area.

@beaulebens, could you point us in the right direction with an example of how that's done, or anybody who's done that recently? We'd be happy to help on this.

@cfinke is focusing on flow fixes this quarter, so I'll tag him here to take a look when he's back from AFK 11/12.

@procifer here's how it's done currently. I apologize in advance 😬

https://github.com/Automattic/jetpack/blob/master/_inc/client/components/admin-notices/index.jsx

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

Was this page helpful?
0 / 5 - 0 ratings