Jetpack: Activity log: events via filesystem should not default to any user

[simison]

_"Plugin installed via Filesystem"_ events default to user:

These should probably just have "Jetpack" as an actor.

[roccotripaldi]

@keoshi - what do you like better for an actor here:

1. The master user ( that's what shows now )
2. A Jetpack actor
3. An "unknown" actor

[keoshi]

This might be a silly question but...what does “via filesystem” mean? Is it when I upload something directly via FTP?

As for your question, I do believe there's value in showing the Jetpack actor here. It wasn't performed by Jetpack, but it is Jetpack that is keeping an eye on changes and reporting back these actions.

[simison]

This might be a silly question but...what does “via filesystem” mean? Is it when I upload something directly via FTP?

Please never feel like any questions are silly. :-)

It could be via ftp or locally at the server downloading the zip and extracting it, or any other method that basically doesn't run through WordPress. Basically the new plugin just "appears" in the plugins folder.

If you're not sure what _“via filesystem”_ means, non-technical customers might be even less sure.

Let's see if there could be more descriptive alternative: we cannot really tell more accurately how exactly the plugin got updated so it has to be vague.

@benhuberman thoughts on how to open up _"Plugin installed via filesystem"_ little more?

It wasn't performed by Jetpack, but it is Jetpack that is keeping an eye on changes and reporting back these actions.

:thumbsup:

[simison]

_"Plugin installed via filesystem"_ alternatives:

• Plugin installed from outside WordPress or Jetpack
• Plugin installed via non-WordPress method
• Plugin installed in plugins folder manually

[keoshi]

Awesome explanation — thanks @simison !

If that's the case and we can't pinpoint the origin, I'd rather go for something like:

Plugin installed manually

• Keeps the description short.
• Everyone knows what manually is.
• Even if it's not a manual operation (via CLI?), advanced users will get the wording, I believe.

[benhuberman]

I'm with @keoshi here -- I like the simplicity and conciseness of "Plugin installed manually," and unless there's some technical use case it doesn't reasonably cover, I'd vote for that.

[keoshi]

@roccotripaldi cleared myself from the assignees list, but let me know where this lives and I'll create a PR.

[roccotripaldi]

No need to create a PR @keoshi - i will make one today! thanks for your input on this!

[roccotripaldi]

Fix deployed in r-176880-wpcom

[keoshi]

Thank you, Rocco!