Jetpack: Users can enable a paid feature "Ads" without being a paid member

[gagan0123]

By default, the features that are "Paid" are disabled in Jetpack, and we don't get a button to enable them, but not for Ads, here's a screencast to reproduce the issue.

[jeherve]

I was able to reproduce on my end as well.

cc @dbspringer

[jeherve]

Fixed in #6811

[dbspringer]

Thanks @gagan0123 and @jeherve for pointing this out/shepherding this while I've had some afk 🙇

[jeherve]

Looks like this issue is back. Reopening.

[rclations]

@jeherve are you still able to reproduce?
I tried testing but it appears the /search route where the toggles were showing in the video above is no longer available.

[jeherve]

Things look better now, I can't reproduce anymore. Closing.

[rachelmcr]

Reopening this as I'm still seeing an issue here — let me know if you'd prefer a new, separate issue for this. If a site had ads enabled and then downgraded their plan, they can't toggle the ads feature on/off but the ads still appear on their site.

I reproduced with these steps:

1. Upgrade a Jetpack site to the Premium plan.
2. Enable Jetpack ads on the site and confirm they appear on the front end.
3. Cancel the Premium plan.
4. Check the front end of the site.

Result: The ads still appear on the front end, even though the plan is cancelled. The module is disabled in WP Admin so there's no way to turn it off from there.

(Issue raised in a user report, internal ref 1082487-zen.)

[rclations]

I think this may be solved by extension of the work done in https://github.com/Automattic/jetpack/pull/9268

[jeherve]

I ran some tests, and although the ads may not disappear right away, they are eventually deactivated by the cron that is run by the WordAds module.

I think this is good to close for now. If we decide to implement something to deactivate the ads faster, we could add a Jetpack::active_plan_supports( 'wordads' ) check to the should_bail function that is run when the ads are rendered.