Jellyfin-web: Login page inputs missing autofill attributes

[advancedslicedbanana]

Describe the bug
On a Jellyfin server login page, the password field incorrectly prompts Safari on iOS and MacOS to suggest new generated passwords rather than suggesting saved passwords. The user field should contain the HTML attribute autocomplete="username" and the password field should contain autocomplete="current-password".

To Reproduce
Steps to reproduce the behavior:

1. Go to login page for a Jellyfin server
2. Click on password field
3. Safari recommends a new generated password

Expected behavior
When selecting user field on login page, browser suggests stored user/password combos if applicable.

Screenshots

System (please complete the following information):

• OS: iOS 12, MacOS Mojave
• Browser: Safari
• Jellyfin Version: 10.0.2.0

[stale[bot]]

Issues go stale after 60d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 7d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

[deanishe]

Mark the issue as fresh by adding a comment

Umm … bump?

This is somewhat annoying. It's quite the dance to get Safari to enter the credentials it has saved in Keychain. For some reason, it really wants to generate a new password.

[anthonylavado]

Ah okay. I didn’t see this because I had iCloud Keychain turned off in favour of another password manager. Moving to web, where this can be fixed.