Image-sequencer: Edge detect is not working correctly

[blurry-x-face]

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

I tried running edge detect in browser and it gave following output (default values)

I tried running edge detect in node and it gave following output (default values)

What did you expect to see that you didn't?

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[blurry-x-face]

@HarshKhandeparkar could you look into this!

[blurry-x-face]

@publiclab/is-reviewers can anyone please look into this!

[harshkhandeparkar]

Looking :mag:

[harshkhandeparkar]

Got a fix! That was very fast.

[harshkhandeparkar]

Can't make out whether it is working or not. sequencer.publiclab.org was working just fine some time back but now even that is not producing the expected output.

[harshkhandeparkar]

Okay, I don't know what to do now. This could even be a browser problem. Now I cannot test it on another browser because FF doesn't work :crying_cat_face:

[blurry-x-face]

Try to repeat following steps:

1. Open beta site
2. Load edge detect module
3. Change the image to this

Save the generated output and then remove the edge-detect step and clear the cache, now follow the following steps:

1. Open beta site.
2. Load this image.
3. Add edge-detect step

Now compare the two outputs.
My results:

Output 1:

Output 2:

@HarshKhandeparkar could you confirm this.

[blurry-x-face]

Okay, I don't know what to do now. This could even be a browser problem. Now I cannot test it on another browser because FF doesn't work

IS also doesn't work on safari :(

[harshkhandeparkar]

OMG! The outputs ARE different! What???

[blurry-x-face]

OMG! The outputs ARE different! What???

:rofl: my reaction exactly

[blurry-x-face]

@HarshKhandeparkar Could you make it work without using gpu.js and confirm if the problem still persists

[blurry-x-face]

@jywarren could you please look into this!

[harshkhandeparkar]

GPU.js is actually only used for blur. If that is working then I don't think it's a GPUjs problem.

[blurry-x-face]

Yea you're right, I just checked.
What do you think the problem could exactly be?

[harshkhandeparkar]

I think I'll work on this for Bug Stomp February.

[harshkhandeparkar]

Hey guys! I think I found out the issue!

It is mixing up images somehow.

[harshkhandeparkar]

The QR image was loaded before loading the flowers.

[harshkhandeparkar]

@publiclab/is-reviewers

[harshkhandeparkar]

FIXED! Opening a PR soon!
@publiclab/is-reviewers