Image-sequencer: Webgl Distort module

[tech4GT]

@jywarren I don't have a lot of experience with out gl based work, could you guide me a little here, I think I just need to pretty much model the fisheye-gl module right, but using webgl-distort npm module?

[VibhorCodecianGupta]

I'd really like to collaborate here, the fisheye-gl with puppeteer opened a lot of avenues. I think we can start with @jywarren 's webgl-distort repository

[jywarren]

Some notes here! https://github.com/publiclab/image-sequencer/issues/299

The key is:

We'll need to refactor webgl-distort to not interact with the HTML DOM, so restructuring it to work with an Image object instead of an image element, in this line:

Thanks both!!!

[VibhorCodecianGupta]

Nice. I'll try mocking it tonight. Hopefully, I can come up with some ideas/code. Will post here ASAP

[tech4GT]

Oh, so we need to edit webgl-distort library then?

[tech4GT]

Also, Vibhor thanks a lot!! Actually we need this fairly quickly since this is a crucial part of the new exporter system, and with my end terms coming in, I really appreciate your help!! :D

[VibhorCodecianGupta]

Let's get this done by the weekend, then? Mine start in about two weeks as well. Let's make it happen @tech4GT

[tech4GT]

Okay fist thing, we need to make the library node compatible, right now requiring it in node is not doing much for me. Then using fisheye-gl as a template let's implement the example code in the readme over at jywarren/webgl-distort
You can open the pr, since I would be able to push code on top of that.

[tech4GT]

Hmm, @jywarren since the script is not too long do you think maybe we can copy and paste the dist file in is source files?
Or do you think we should edit the jywarren/fisheye-gl??

[jywarren]

I think we should edit the library separately, but you could start by doing
it locally and we can switch to requiring it later?

On Wed, Apr 17, 2019, 11:40 AM Varun Gupta [e-mail] wrote:

Hmm, @jywarren https://github.com/jywarren since the script is not too
long do you think maybe we can copy and paste the dist file in is source
files?
Or do you think we should edit the jywarren/fisheye-gl??

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/1021#issuecomment-484144319,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ8oBf-FqgazD2egapDRApGm1DrOTks5vh0BFgaJpZM4c1S3i
.

[Divy123]

Looks interesting!
Please count me in!!

[VibhorCodecianGupta]

@Divy123 head over to the PR for the issue if you will, I could use some ideas there. Mentioned some scopes of improvement on the issue comments there

[jywarren]

1022 !!