Image-sequencer: Depend on gifshot via node_modules and package.json

Created on 12 Jan 2019  路  5Comments  路  Source: publiclab/image-sequencer

gifshot is a big library - we should include it via npm! https://www.npmjs.com/package/gifshot

https://github.com/publiclab/image-sequencer/blob/main/examples/gifshot.js could be removed, and the reference in index.html could be pointed at /node_modules/ instead.


This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/is-reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

fto-candidate help wanted

All 5 comments

Hello!
I have previously solved a fto issue and got the changes merged.
I would like to work on solving this or make this a fto-candidate.

@vrk99 you can go ahead and reformat this issue as an fto in a different issue and mention publiclab/is-reviewers to add the label.

You can resolve it too as a second time contribution if you want.

New FTO created https://github.com/publiclab/image-sequencer/issues/687

I think this can be closed.

I am closing this as this has been reformatted already.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

harshkhandeparkar picture harshkhandeparkar  路  4Comments

harshkhandeparkar picture harshkhandeparkar  路  4Comments

jywarren picture jywarren  路  5Comments

harshkhandeparkar picture harshkhandeparkar  路  5Comments

Divy123 picture Divy123  路  5Comments