Image-sequencer: Image downloading on image click is undesirable

[Divy123]

Please describe the problem (or idea)

Every time and most of the time by mistake, we click on an image it gets downloaded which is most of the time undesirable

Solution

A download image button can be added to the panel for this purpose .

[Divy123]

CC: @jywarren @HarshKhandeparkar

[harshkhandeparkar]

Wasn’t it added. It was discussed

[Divy123]

No its not added yet!
Can you point out towards the issue?

[harshkhandeparkar]

It was a very old issue. It is probably closed now. I had discussed this with someone else as well but I don’t remember who. It was probaby harshith in his panel pr.

[Divy123]

Ohh so I think we can continue upon this here!!

[harshkhandeparkar]

Yes sure. Also I would request you to have a look at https://github.com/publiclab/image-sequencer/issues/849#issuecomment-483733931

[Divy123]

@jywarren what are your views here?

[harshkhandeparkar]

I had actually done this in the Materialize renderer. The image was materialboxed. Have you seen it?

[harshkhandeparkar]

Link to materialbox docs https://materializecss.com/media.html. We can do something similar to the current bootstrap UI or we can add click to select pixel functionality. Either one of those. I would now actually prefer the latter. Your thought?
@jywarren

[Divy123]

@HarshKhandeparkar I think that is quite cool.
Also what do you think on adding a download button?
Sorry if I am missing something.

[VibhorCodecianGupta]

@HarshKhandeparkar is this a separate bundled library? I think we can implement the click to select pixel feature easily with the native JS canvas as well, as a separate input type, to reduce the load of an extra library

[harshkhandeparkar]

@Divy123 img download button is ready to go :rocket:!
I was thinking of what we can do with the img when it is clicked.

@VibhorCodecianGupta Materialbox is a modified verison of lightbox. Modified in materializecss. It is used for responsize imgs. Better image preview etc. I mean that you can click on the img to enlarge, zoom into it etc. Hovering over it will add a white mask.

When I had added it to the Materialize renderer, I didn't think of the click to add pixel. I had already added a separate button tor download and the image had nothing so I "materialboxed" it.

[harshkhandeparkar]

Wait I'll drop links to some screenshots/gifs

[harshkhandeparkar]

• WIP draft PR: https://github.com/publiclab/image-sequencer/pull/825
• Scroll down from here to get billions of screenshots and GIFs: https://github.com/publiclab/image-sequencer/issues/708#issuecomment-457604566

[harshkhandeparkar]

I think lighthox is a jQuery plugin but I'm not sure.

[Divy123]

@HarshKhandeparkar what's the progress in this one?

[harshkhandeparkar]

what's the progress in this one?

@VibhorCodecianGupta?