Image-sequencer: add second spinner icon in step header

[jywarren]

Let's consider a second spinner in the step title header, so that when steps are collapsed, the spinner still runs.

We'd love help with this one! Thanks!!!

[gitmate[bot]]

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/513 (add a "start a new sequence" button in the header), https://github.com/publiclab/image-sequencer/issues/516 (Show spinner icon while gif is generating), https://github.com/publiclab/image-sequencer/issues/547 (Add Step button and select fields not inline ), https://github.com/publiclab/image-sequencer/issues/363 (add placeholder when brightness step applied), and https://github.com/publiclab/image-sequencer/issues/498 (Add toggle button next to step name).

[gitmate[bot]]

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/513 (add a "start a new sequence" button in the header), https://github.com/publiclab/image-sequencer/issues/516 (Show spinner icon while gif is generating), https://github.com/publiclab/image-sequencer/issues/547 (Add Step button and select fields not inline ), https://github.com/publiclab/image-sequencer/issues/363 (add placeholder when brightness step applied), and https://github.com/publiclab/image-sequencer/issues/498 (Add toggle button next to step name).

[VibhorCodecianGupta]

I'd like to work on this!

[jywarren]

Please go ahead!!

On Jan 11, 2019 2:15 PM, "Vibhor Gupta" [e-mail] wrote:

I'd like to work on this!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/657#issuecomment-453626250,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ-hrdVb6SaaPwNrTE-EWYEzGpsMzks5vCOK8gaJpZM4Z8BPf
.

[VibhorCodecianGupta]

@jywarren Could you elaborate on this a bit? Just so I know I am getting this right? Anyway, this will get fixed only after #651 when the UI is working fine

[aashna27]

@VibhorCodecianGupta I have already implemented this , actually @jywarren gave this idea in toggle-collapse's pr so I did it and I wasn't aware of this issue, so I couldn't claim it earlier. Have you started working on this ?

[VibhorCodecianGupta]

No, that's fine @aashna27 if you've implemented, great! However I still don't completely get the ask of this issue, can you explain what is it exactly?

[aashna27]

yeah sure !

Also thank you so much @VibhorCodecianGupta and I am really sorry. 🙍

[VibhorCodecianGupta]

@aashna27 this looks super cool! Also, no need to be sorry! Doesn't matter who does it as long as the community keeps adding good code.

[aashna27]

@aashna27 this looks super cool! Also, no need to be sorry! Doesn't matter who does it as long as the community keeps adding good code.

That's really sweet of you. 😄

[VibhorCodecianGupta]

That's really sweet of you. 😄

Thanks for the great work 😄

@aashna27 a little brainstorming if I may, would it look better if the spinner is aligned to the far right? towards the end of the separator, that is? What do you think @jywarren ?
It would look uniform for every module then, rather than adjusting itself according to the length of the step name

[aashna27]

Yess seems a nice one, would make a pr once the toggle pr is merged, will make changes according. Happy to hear more suggestions.

[jywarren]

HI, this is great! I opened a new issue for a Panel ui which can
potentially help with the refinements to UI. Take a look! Also the toggle
PR is merged. Thanks!

On Sun, Jan 13, 2019 at 12:41 PM aashna27 [e-mail] wrote:

Yess seems a nice one, would make a pr once the toggle pr is merged, will
make changes according. Happy to hear more suggestions.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/657#issuecomment-453850040,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJw8hD_yHfrj8BtqWf9DBif0-3f-jks5vC2-1gaJpZM4Z8BPf
.

[jywarren]

For example the spinner might appear to the right side in the panel UI? Anyways there are more possibilities. Awesome!

[aashna27]

how does this seem ? @jywarren @VibhorCodecianGupta

[aashna27]

HI, this is great! I opened a new issue for a Panel ui which can potentially help with the refinements to UI. Take a look! Also the toggle PR is merged. Thanks!

yes had a look at it, seems a good improvement .. currently I thought of doing in the original UI considering the pr backlog as you mentioned there.Is it okay ?