Image-sequencer: Add resize module to list of quick buttons

Created on 26 Nov 2018  Â·  11Comments  Â·  Source: publiclab/image-sequencer

This issue is a sub-issue of #487 , which is to be broken down into smaller issues.

In the image-sequencer, there are a list of quick-buttons so the user can add commonly-used layers quickly:
image

What we want to do is to add another quick-add button for the resize functionality. Here's the todo for this task:

  • [ ] Find a suitable icon on font-awesome and link it here make sure it's from the v4.5 icon set!
  • [ ] Add the icon in the appropriate button style in examples/index.html.
    image
  • [ ] Keep in mind the proper syntax for data-value, which can be checked by navigating to the proper component in src/modules. It is lowercase

Please show us where to look

http://sequencer.publiclab.org/examples/#steps=

What's your PublicLab.org username?

JonathanXu1

Browser, version, and operating system

Firefox63, Windows 10


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

HTML enhancement small

Most helpful comment

fine i will open the pr jst wait a min

All 11 comments

GitMate.io thinks the contributors most likely able to help are @oorjitchowdhary, and @welcome[bot].

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/492 (Add the Resize module to the quick buttons bar), https://github.com/publiclab/image-sequencer/issues/432 (display add step menu with common modules as "quick" buttons), https://github.com/publiclab/image-sequencer/issues/433 (display add step menu with common modules as "quick" buttons), https://github.com/publiclab/image-sequencer/issues/27 (add fisheyegl module), and https://github.com/publiclab/image-sequencer/issues/138 (Add a Dithering module).

GitMate.io thinks the contributors most likely able to help are @oorjitchowdhary, and @welcome[bot].

Possibly related issues are https://github.com/publiclab/image-sequencer/issues/492 (Add the Resize module to the quick buttons bar), https://github.com/publiclab/image-sequencer/issues/432 (display add step menu with common modules as "quick" buttons), https://github.com/publiclab/image-sequencer/issues/433 (display add step menu with common modules as "quick" buttons), https://github.com/publiclab/image-sequencer/issues/27 (add fisheyegl module), and https://github.com/publiclab/image-sequencer/issues/138 (Add a Dithering module).

great work!!

On Mon, Nov 26, 2018 at 5:33 PM gitmate[bot] notifications@github.com
wrote:

GitMate.io https://gitmate.io thinks the contributors most likely able
to help are @oorjitchowdhary https://github.com/oorjitchowdhary, and
@WELCOME https://github.com/WELCOME[bot].

Possibly related issues are #492
https://github.com/publiclab/image-sequencer/issues/492 (Add the Resize
module to the quick buttons bar), #432
https://github.com/publiclab/image-sequencer/issues/432 (display add
step menu with common modules as "quick" buttons), #433
https://github.com/publiclab/image-sequencer/issues/433 (display add
step menu with common modules as "quick" buttons), #27
https://github.com/publiclab/image-sequencer/issues/27 (add fisheyegl
module), and #138
https://github.com/publiclab/image-sequencer/issues/138 (Add a
Dithering module).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/499#issuecomment-441826255,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2D6QTY4Pm2hASm6b0bccCxhXk8rks5uzGwKgaJpZM4Yz9Pz
.

Was this a open issue?? Can i work on it??

Go ahead @Harshithpabbati

resize
@HarshKhandeparkar I am almost done with it.But i cant get the image on the resize module.Can you help me out??

@Hashithpabbati you will have to use some fontawesome icon. Choose an appropriate icon from here

Oh wait, the image you provided didn't load for me. Sorry, I though you were asking something else. Can you please open a pr or give me a link to your branch? Btw you have to change the examples/lib/intermediateHtmlStepUi.js file too. @Harshithpabbati

Oh wait, the image you provided didn't load for me. Sorry, I though you were asking something else. Can you please open a pr or give me a link to your branch? Btw you have to change the examples/lib/intermediateHtmlStepUi.js file too. @Harshithpabbati

Yeah i made the change in the intermediateHtmlStepUi.js
I used the font-awesome icon though i couldn't get the icon

Are you going to open a PR? Or atleast provide me a link to the branch so that I can help you in troubleshooting.

fine i will open the pr jst wait a min

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kindanduseful picture kindanduseful  Â·  5Comments

jywarren picture jywarren  Â·  4Comments

jywarren picture jywarren  Â·  4Comments

jywarren picture jywarren  Â·  5Comments

harshkhandeparkar picture harshkhandeparkar  Â·  4Comments