Image-sequencer: Change the warning log

Created on 1 Mar 2018  ·  9Comments  ·  Source: publiclab/image-sequencer

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The problem

We need to fix the following log

https://github.com/publiclab/image-sequencer/blob/973ec6d6e47fff49381e7c4b32c9b87f3947862c/index.js#L60

Solution
Change the log to say "Please wait \n output directory generated will be empty until the execution is complete"

Steps to fix

Claim

  • [ ] this
  • [ ] issue with a comment
  • [ ] set up a repository locally and make sure that all tests pass
  • [ ] start a pull request (see contributing to Public Lab software) but mark it as "in progress"
  • [ ] fix the issue following the steps above
  • [ ] make sure all tests pass
  • [ ] alert someone via either the developers list (see below) to have your pull request merged. This may take a few extra steps depending on when you do it, but we'll help you out!
  • [ ] Please email the developers list (see https://publiclab.org/developers) if you have questions!
first-timers-only help wanted

All 9 comments

GitMate.io thinks the contributors most likely able to help are @jywarren, and @danielleshwed.

Possibly related issues are #187 (Add documentation about the debug script), and #170 (Output not generated if contents of output folder are deleted).

@jywarren since our execution is not exactly async, maybe this will be a more suitable log😁

Yes!!!!

On Thu, Mar 1, 2018, 2:50 AM Varun Gupta notifications@github.com wrote:

@jywarren https://github.com/jywarren since our execution is not
exactly async, maybe this will be a more suitable log😁


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/194#issuecomment-369519152,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxzqXv5aVEqYKTXiaTXQCPk11c9mks5tZ7YwgaJpZM4SX8jI
.

I want to work on this.

@Ronaq13 hello there, welcome to the community😁
I assign the issue to you👍
Thanks a ton

That'll be great @Ronaq13!

On Fri, Mar 2, 2018, 09:02 Varun Gupta notifications@github.com wrote:

@Ronaq13 https://github.com/ronaq13 hello there, welcome to the
community😁
I'll assign the issue to you now
Thanks👍


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/194#issuecomment-369809921,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT0xnJC7gvemV9P7KhZJDR7i8J5VQ0VCks5taL1bgaJpZM4SX8jI
.

Hello. I am new to the open-source community and Public Lab. It seems that this issue is still open despite a previous user expressing desire to work on this. Could I please be assigned this issue to help me get started?

Looking at index.js, I see that this has already been completed. It would probably be a good idea to close this issue so that others don't attempt to complete it.

@tspakes sorry for the inconvenience. Welcome to publiclab community try a first timers issue to get started😁

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vaibhavmatta picture vaibhavmatta  ·  4Comments

keshav234156 picture keshav234156  ·  4Comments

harshkhandeparkar picture harshkhandeparkar  ·  3Comments

harshkhandeparkar picture harshkhandeparkar  ·  4Comments

sashadev-sky picture sashadev-sky  ·  3Comments