Id: Mapillary sign detections shown selectively

[tohaklim]

Not sure if this is something due to a change on Mapillary's side, but the Signs overlay doesn't always show me the sign which is nonetheless highlighted as a detection in the image window (which remains broken as per 6286.)
Viewing the image preceding the one with the sign - you can see there is no detection, nothing blocked by the viewer cone

And the image with the sign itself

[cbeddow]

I believe this is due to a limit set in the OSM iD code, which allows only so much "tiling" of the traffic signs. When the Mapillary API is called, it tries to paginate through all data (1000 signs per request) but has something in the iD code with a limit of 5, which I am not sure if it's 5 iterations of tiling. This is my theory, but I am not sure exactly why this happens.

See here: https://github.com/mapillary/iD/blob/feature/mapillary-organization-filters/modules/services/mapillary.js#L397

@quincylvania do you know what this limit is?

This will be fixed in a future iD version by using vector tiles instead of the API.

[tohaklim]

Ah, I mistakenly thought iD transferred to vector tiles already, obviously that's not the case

[tohaklim]

Looks like this and #6721 can be merged, as both appear to be caused by the same pagination bug

[cbeddow]

Fixed with https://github.com/openstreetmap/iD/pull/6921, pull request pending, can close after testing. I found Chiang Mai in this intersection showed the difference well: https://www.openstreetmap.org/edit#map=19/18.78540/98.99043

before:

after: