Id: Phone numbers should be valid on businesses inside converted houses

Created on 21 May 2019  Â·  3Comments  Â·  Source: openstreetmap/iD

A house that has been converted to a law office would be tagged building=house office=lawyer and would ideally be tagged with a phone number. But the validator flags the phone number as being a potential privacy violation:

personal

Per https://github.com/openstreetmap/iD/issues/5850#issuecomment-475033614, there is logic to exempt features with certain keys. Any business-specific key like office, brand, or website should be added to that heuristic. (Regarding website, self-hosted personal homepages are less common these days, so I figure it’s more likely to indicate the presence of a business.)

bug validation

Most helpful comment

iD won't flag residential buildings that also have one of these tags, so we can just add office to this list.

https://github.com/openstreetmap/iD/blob/d4d78b408154b4c32b21987d8f48fc673c5c17e1/modules/validations/private_data.js#L20-L28

All 3 comments

Oh yeah, I've seen this a few times too. Usually I end up just changing the building type to - not one of these:
https://github.com/openstreetmap/iD/blob/d4d78b408154b4c32b21987d8f48fc673c5c17e1/modules/validations/private_data.js#L10-L18

iD won't flag residential buildings that also have one of these tags, so we can just add office to this list.

https://github.com/openstreetmap/iD/blob/d4d78b408154b4c32b21987d8f48fc673c5c17e1/modules/validations/private_data.js#L20-L28

Usually I end up just changing the building type to - not one of these

building=house is correct tagging – it remains architecturally a house – though building:use could be set to something else like commercial.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bhousel picture bhousel  Â·  3Comments

Chaz6 picture Chaz6  Â·  3Comments

tordans picture tordans  Â·  3Comments

tordans picture tordans  Â·  3Comments

scaidermern picture scaidermern  Â·  3Comments