Id: "Oudated tag" conversion overwrites modern tags that are already there

[danstowell]

Hi - I edited a restaurant and saw the "Outdated tags. Update?" dialog so I clicked yes. I think it was referring to the outdated cuisine=vegetarian. However, the object already had the more modern tag in place, it had diet:vegetarian=only. The iD editor automatically deleted the old tag but overwrote the modern tag with diet:vegetarian=yes which is a worse tag than what was already there. I'm not here to debate only-vs-yes, the general point is:

If the modern tag is already in place, iD should not overwrite it with autogenerated values.

[kymckay]

What was the restaurant?

[danstowell]

https://www.openstreetmap.org/node/1936469261

[kymckay]

Ah I see now what you mean, I thought it might be something to do with the name suggestion index and a branded location at first.

Interesting edge case. Basically iD should defer to an existing value for a key when adding tags in an quick fix.

[quincylvania]

@danstowell Thanks for finding this! It was definitely unintentional and has been fixed.