Id: Low performance of changeset comment field

Created on 28 Apr 2019  路  3Comments  路  Source: openstreetmap/iD

For the changeset comment field, I still have the issue from https://github.com/openstreetmap/iD/issues/6054

Its really bad when I type my commit message. I type and nothing happens and then the text appears all at once.

I took some of those Google Chrome performance screenshots. But I don't really know how to read them, so I don't know what parts are useful.

Do I read it right, that every key press triggers some big re-rendering action?

Bildschirmfoto 2019-04-28 um 06 39 16

Bildschirmfoto 2019-04-28 um 06 39 30

Bildschirmfoto 2019-04-28 um 06 40 14

performance

All 3 comments

Yes thanks for ticketing - I know about this and tried addressing it in https://github.com/openstreetmap/iD/pull/6140/commits/ae06e28f9ba7068efcfe082376f7ba7fa1fbcf51
But realized then that it didn't completely fix the issue.

This is why I'm pushing on the d3 upgrade this week in #6245 - to eliminate that as one potential source that might trigger the style recalculation.

Also worth mentioning - if you are using the profiler, you should uncheck the "screenshots" feature, because that will slow things down even more and possibly mask the actual source of the slowness you're investigating.

I can confirm, the changeset comments field feels snappy again.

For comparison:
(From "click on save-button to click on commit-button")

Bildschirmfoto 2019-05-01 um 07 22 22

Bildschirmfoto 2019-05-01 um 07 23 31

Bildschirmfoto 2019-05-01 um 07 24 07

Was this page helpful?
0 / 5 - 0 ratings