Hi there ππΌββοΈπ
Link to my theme repository: https://github.com/janraasch/hugo-scroll
README.md describing my themeLICENSE.mdtheme.tomlimages/ folder with the required dimensionshttps://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domainstoCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of HugoI don't have a Twitter-account, but I sure would not mind a mention of my website https://www.janraasch.com on Twitter :-).
Please let me know, if you need anything else from my side.
Thank you β₯οΈ and keep up the great work π.
This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.
Hi stale (bot), please be patient :-). Let's at least wait for one of the maintainers to reply here.
Hi Jan,
excuse the delay. I was busy with the preperation of an exam that I wrote today. I plan to review the theme submissions in the upcoming days.
No worries. Take your time and thank you for the heads-up. I hope the exam went amazing π₯ :-).
Hello again,
first of all, thanks for sharing your theme with the Hugo community. During the review the only issue I noticed was that the header image on the very top of your theme isn't when running the build script for www.themes.gohugo.io.
While your demo is hosted at http://localhost:1313/theme/hugo-scroll/ the image links due to relURL to /images/cover-image.jpg. Thus the image's path is relative to the root of the domain (http://localhost:1313/), not to http://localhost:1313/theme/hugo-scroll/. By not using relURL you keep the path as images/cover-image.jpg, which works fine as for the images in the sections below.
Hi there @digitalcraftsman ππ», thank you for taking the time to review this.
During the review the only issue I noticed was that the header image on the very top of your theme isn't when running the build script for www.themes.gohugo.io.
Nice catch π . I removed the usage of relURL via https://github.com/janraasch/hugo-scroll/commit/0fe91fc202581e817fccc29169255fe9a1b9bccb.
Please try again.
Kind regards and have a nice weekend,
Jan
Thanks for applying the fix. Your theme is already live on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.
Kind regards and have a nice weekend,
Likewise Jan
Awesome, @digitalcraftsman. Thank you very much β€οΈ π. I am proud to be a part of the Hugo community π.
I'm looking forward to the announcement on Twitter https://twitter.com/gohugoio π π.
Have a good start into the Β»workΒ«-week π π.
Awesome, @digitalcraftsman. Thank you very much β€οΈ π. I am proud to be a part of the Hugo community π.
Thanks for giving something back π
I'm looking forward to the announcement on Twitter twitter.com/gohugoio π π.
tl;dr: for an unknown reason my Twitter account (not @ gohugoio) has been suspended by inadvertently trigger some filter or something alike. Thus, I'm currently not able to post anything through (@ gohugoio). I've contacted Twitter's support to resolve the issue. I'll reopen this issue as a reminder for the announcement.
Have a good start into the Β»workΒ«-week π π.
You as well and happy Hugoing.
Your theme has now been promoted on Hugo's official Twitter account as well (see https://twitter.com/GoHugoIO/status/1301896092574011394).
That's great. Thank you very much, @digitalcraftsman π.
Most helpful comment
Your theme has now been promoted on Hugo's official Twitter account as well (see https://twitter.com/GoHugoIO/status/1301896092574011394).