Hugothemes: new theme SimpleIT Hugo Theme

[marcanuy]

Link to my theme repository: https://github.com/marcanuy/simpleit-hugo-theme

[onedrawingperday]

Hi @marcanuy

Thank you for your submission!

• You need to commit your /resources/ directory with the generated CSS. Hugo Themes should work for all versions of Hugo not only for Hugo Extended.

---

Furthermore in your Example Site's config you need to make the following changes:

• Change line 4 to the following: theme = 'simpleit-hugo-theme'

• Comment out line 5 and delete your Google Analytics ID.

• Comment out line 25 and remove your AdSense ID

• Line 28 remove your Google Webmaster Tools verification meta.

• Comment out line 31 and remove your Bing Webmaster Tools verification meta.

• Comment out line 34 and remove your Yandex Webmaster Tools verification meta.

---

Let me know once you do the above so that I can look into your theme further.

Thanks!

[marcanuy]

Hey @onedrawingperday thanks for having a look at it.

Adsense, webmaster tools, bing and yandex are just placeholders, they contain 1234567890. They won't have any effect on a site using them if they don't verify them, I could remove them anyway but I have a doubt:

If Hugo extended isn't supported, is there any way to publish the theme? I'm using Hugo Pipes so it needs the extended version.

[onedrawingperday]

If Hugo extended isn't supported, is there any way to publish the theme? I'm using Hugo Pipes so it needs the extended version.

As I said above you need to generate the resources that depend on Hugo Pipes locally with the command hugo server and then commit the directory under the root of your theme. Have a look at the repository of the Hugo Tale theme for an example.

Regarding the parameters for the various services in your Example Site’s config keep them as they are but please comment out these lines.

Sorry I didn’t notice that their values were just placeholders. (Silly me).

Let me know once you commit the resources in your theme so that I can have a further look.

Thanks!

[marcanuy]

I wasn't aware of the role of the resources directory, now it makes sense! I've aready updated the repo with their contents and removed the requested parameters.

[onedrawingperday]

@marcanuy
Now your theme's demo renders.

However there are various missing icons when I test your Example Site, both with the Build Script and when I simply run hugo server.

It seems that you have missed the import for the Font Awesome JavaScript files. Please see their Docs and include the icons.

Also the Twitter, Facebook, Google Plus and Buy Me A Coffee buttons are missing.

Let me know once you look into the above, so that i can test further.

Thanks!

[marcanuy]

Sorry for that, I had Fontawesome webfonts out of version control but it is already fixed, I've also removed the "Buy me a coffee" from the example site.
Tested with the non extended Hugo version 0.46 with the /exampleSite and with HugoBasicExample. Everything is working as expected with no warnings in browser's console.

[onedrawingperday]

@marcanuy

Ok. Font Awesome icons are present now however the bigger problem is the way you have structured your theme.

• Can you please tell me what is the purpose of the /docs/ directory under the root of your theme?

• The contents of the above seem to be pure HTML files that do not use Hugo templates, such as the one under: /simpleit-hugo-theme/docs/baz-first-level-section/

• It seems that the /docs/ directory should be part of the Example Site content, not the theme.

• Furthermore when I click Search in your footer menu I get a 404. I understand that you use a partial containing code for Google Custom Search, but you should have this enabled for the purposes of your theme's demo.

• Also I think that you need to remove the following notice from the footer of your pages: Except as otherwise noted, the content of this page is licensed under CC BY-NC-ND 4.0

• Your pages contain dummy content, there is no need for such a notice in an Open Source Theme. Make it a parameter in your config so that users can put whatever notice they want easily instead of having to customize a partial.

• Also I noticed that you have not included your Theme's favicons under /static/favicons/

• And on a final note rather than constructing your URLs like this: {{.Site.BaseURL}}favicons/apple-touch-icon-120x120.png it's better practice to use the absURL function like so: {{ "favicons/apple-touch-icon-120x120.png" | absURL }}

Please look into the above and let me know.

Thanks!

EDIT
The Facebook and Twitter buttons work properly after all. They were not rendering for me earlier, because I have blocked all scripts from these sites in my browser.

[marcanuy]

Can you please tell me what is the purpose of the /docs/ directory under the root of your theme?

/docs is one of the methods to have Github render a Github docs site, in this case it is used by: https://marcanuy.github.io/simpleit-hugo-theme/

Furthermore when I click Search in your footer menu I get a 404. I understand that you use a partial containing code for Google Custom Search, but you should have this enabled for the purposes of your theme's demo.

Removed search link from footer *

Also I think that you need to remove the following notice from the footer of your pages: Except as otherwise noted, the content of this page is licensed under CC BY-NC-ND 4.0

Changed license to a config parameter. *

Also I noticed that you have not included your Theme's favicons under /static/favicons/

Removed favicons partial and added a custom head partial to include favicons or anything else. *

Ok. Font Awesome icons are present now but the Twitter and Facebook buttons are still not rendering

These button just load the default share widgets from Twitter and Facebook, they are working in all my tests (1, /exampleSite, and HugoBasicExample), can you please check if there is any error in browser's console? They should work without problems

[onedrawingperday]

These button just load the default share widgets from Twitter and Facebook, they are working in all my tests (1, /exampleSite, and HugoBasicExample), can you please check if there is any error in browser's console? They should work without problems

OK. The buttons work after all. I didn't see them originally because -as I said above- I have set up my browser to block all tracking scripts from Facebook, Twitter and other third party sites.

/docs is one of the methods to have Github render a Github docs site, in this case it is used by: https://marcanuy.github.io/simpleit-hugo-theme/

Ok. Thanks for the info. (I just checked that other Hugo themes also use this GitHub feature). So keep the /docs directory as you have it.

Regarding the other changes thanks for making them!

Your Example Site renders without errors when I execute the Build Script. 👍

@digitalcraftsman This theme is ready to be added to the website.

[digitalcraftsman]

@marcanuy thank you for sharing this theme with the Hugo community :+1:

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.