Hugothemes: Add minimage theme

[dsk52]

Hi, I create a theme.
d-kusk/minimage: [WIP] Hugo's theme : https://github.com/d-kusk/minimage/tree/master

When you check theme, please show branch for 'develop'.
'develop' branch is used for development. 'master' branch is used for distribution.

Can I add it to the theme list if there is no problem?

[digitalcraftsman]

Hello @d-kusk

thanks for sharing another theme with us :+1: Your theme should be listed soon on the themes site.

When you check theme, please show branch for 'develop'.
'develop' branch is used for development. 'master' branch is used for distribution.

With this setup I would reference the stable version of your theme on the master branch. Hence I would check only this version. Can you tell me, why I should have a look at the develop branch?

I noticed that the thumbnails of the demo posts aren't shown because they're linked relative to the root directory. But all demos are hosted in a subdirectory (www.example.com/themes/minimage). You can use the absURL template function to take care of this.

[dsk52]

Hi, @digitalcraftsman
Thank's for check.

With this setup I would reference the stable version of your theme on the master branch. Hence I would check only this version. Can you tell me, why I should have a look at the develop branch?

It is OK to check the master branch. However, since the master branch is overwritten in the form of a newly created CI tool, it is difficult to understand the change.
So, if you want to see the difference, it is okay to have a look at the develop branch.

I noticed that the thumbnails of the demo posts aren't shown because they're linked relative to the root directory. But all demos are hosted in a subdirectory (www.example.com/themes/minimage). You can use the absURL template function to take care of this.

Thank you for teaching me.
I fixed about this matter.

[digitalcraftsman]

It is OK to check the master branch. However, since the master branch is overwritten in the form of a newly created CI tool, it is difficult to understand the change.

Using a stable version of your theme, i.e. the master branch, would be the obvious choice. As the name already suggests people would check out the develop branch if they want to see the latest and greatest additions. But develop also sounds a bit like a beta version. With this in mind, do you want to see the master branch to be used as source for the demos on https://themes.gohugo.io ?

For users of your theme it might not be beneficial if the CI bot overwrites the commit history of the master branch and replaces it always with a single commit. If a user adds a theme as a submodule a specific commit, which is sort of a version for your theme, can be outdated. This makes it more difficult to use an older version of your theme.

[dsk52]

I see ... that is true.
I will review the way to do it.

[digitalcraftsman]

Hi @d-kusk,

are there any news regarding your theme?

[dsk52]

Hi, @digitalcraftsman

Sorry, I do not know how to do it, it has not changed. I'd like to divide the branch for development and for distribution ...

Perhaps it would be better to have Issue closed once.

[dsk52]

@digitalcraftsman

Sorry it got late.
I changed the operation method of git so that the history can be seen even in the master branch.
How about this? :(

Can you check it when time is up?

[ghost]

Cool looking theme @d-kusk. Looking forward to seeing it enter the theme gallery.

[onedrawingperday]

Hi @d-kusk

I had a look at your Minimage theme (the master branch) and I found the following issues:

In config.toml of your example site currently you have the following parameters:

baseurl = "Your Site URL"
languageCode = "Your language code"
canonifyurls = true

• Specify a valid baseURL like https://www.example.com or even /
• Provide a valid languageCode such as en
• canonifyurls is on the roadmap to be deprecated (see: https://github.com/gohugoio/hugo/issues/4733) so I suggest you remove it.
• You have not specified a theme parameter. Please enter theme = "minimage"

Furthermore

• You have specified the same '/img/hot_sunny_weather.jpg' as the background image of all your posts, even though you have other images under /static/. I suggest you make the example site look like the screenshot you have in your repository.

• When I click the hamburger icon there is no menu in the modal window that opens. You should either provide a menu for the theme's users (preferably through the config) or simply remove the hamburger icon and the modal code from your theme.

• Also your images are still missing when I execute the Build Script despite the absURL fix that @digitalcraftsman suggested above. This happens because in the front matter of your posts you have entered image: '/img/hot_sunny_weather.jpg'. Please remove the first slash / like so: image: 'img/hot_sunny_weather.jpg'.( When you specify a URL with a slash in the beginning Hugo turns it into a relative link and absURL has no effect. You need to change this parameter in all your posts).

• And finally change line 20 of your single.html to the following: <div class="c-thumb c-bg-img" style="background-image: url('{{ .Params.image | absURL }}')"></div> (You didn't include absURL in this template).

Please look into the above and let me know, so that I can test you theme further.

Thank you!

[dsk52]

@onedrawingperday
Thanks for checking! Very polite and easy to understand!
I will contact you again if I can fix it, I would like you to see it at that time.

[dsk52]

Hi @onedrawingperday

I fixed it. Could you check it again?
The place to specify the file path of the image is not confident for a moment, but can you look around that emphatically ...?

[onedrawingperday]

Hi @d-kusk

Thank you for making the changes!

When I test your theme's Example Site with the Build Script everything renders fine now! 👍

Images show up and they're different in each post, the modal menu has links. 🥇

There is only one small detail in the README, please make the link to the screenshot of your theme absolute like this: https://raw.githubusercontent.com/d-kusk/minimage/develop/images/screenshot.png

Do this small change and I will mark your theme as ready to be added to the website!

[dsk52]

@onedrawingperday
Thanks for check! 👍

I changed URL for screenshot. Maybe it's okay, can you check it?

I am looking forward to being added to the website!!

[onedrawingperday]

@d-kusk Everything is fine on my end! 👍

@digitalcraftsman The Minimage theme is finally ready to be added to the website!

[digitalcraftsman]

@d-kusk I've added your theme adn it should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

[dsk52]

@digitalcraftsman
Thank you! I also saw tweets!

@jhabdas The theme was released!