Handbrake: Build fails on OS X downloading yasm 1.3.0

[joshrabinowitz]

Description of problem or feature request

Build using scripts/mac-toolchain-build ~/handbrake fails on OS X downloading yasm 1.3.0

Steps to reproduce the problem

• Checkout repo
• run scripts/mac-toolchain-build ~/handbrake

HandBrake version (e.g., 1.0.0)

Commit 115725538ac2244a03ba0678e2669e0e354a3efc , master branch

Operating system and version (e.g., Ubuntu 16.04 LTS, macOS 10.3 High Sierra, Windows 10 Creators Update)

macOS 10.13.5 (17F77)

Error message text or screenshot

% scripts/mac-toolchain-build ~/handbrake
Downloading [06/06] yasm 1.3.0 [FAIL]
Logs and temporary files remain at: /var/folders/_9/1yt1jp1s4w76wjj0bd7gbws000017w/T/toolchain-IE5nZr

HandBrake Activity Log required (see https://handbrake.fr/docs/en/latest/help/activity-log.html)

Not Applicable

~
~

I suspect that the problem is that the certificate for https://www.tortall.net/projects/yasm/releases/yasm-1.3.0.tar.gz has expired. Firefox reports:

www.tortall.net uses an invalid security certificate. The certificate expired on June 5, 2018, 4:33 AM. The current time is June 5, 2018, 8:10 AM. Error code: SEC_ERROR_EXPIRED_CERTIFICATE

[bradleysepos]

Yes, appears to be an upstream certificate issue. In the meantime, you can configure HandBrake with --enable-local-yasm but this is going away very soon, see #1378.

[bradleysepos]

You can also build yasm yourself according to the commands in mac-toolchain-build. Verify your download (shasum -a 256 yasm-1.3.0.tar.gz) with the hash here: https://github.com/HandBrake/HandBrake/blob/115725538ac2244a03ba0678e2669e0e354a3efc/contrib/yasm/module.defs#L6

I hope to get hash verification into mac-toolchain-build when I have time.

[joshrabinowitz]

Maybe it makes sense to download the tarball from https://github.com/yasm/yasm/archive/v1.3.0.tar.gz instead as mentioned at https://github.com/yasm/yasm/issues/106

[PeterJohnson]

Fixed upstream.

[bradleysepos]

Thanks @PeterJohnson. 😸