Guake: Guake not taking the entire width of the screen

[ghost]

For a while, Guake has left some ten or so pixels of empty space on the right side of the screen (screenshot below because I suck at describing things). I have tried aligning center, left, and right, and nothing fixes it. I also have a screenshot of my preferences. Using the most current version of master as of the time of writing.

[pypingou]

Could it be the space for the scrollbar?

[gsemet]

can you describe your system, version, gnome version, if you have 1 or 2 screens?

[ghost]

@pypingou it isn't, the scrollbar is contained in the terminal

@Stibbons Running a clean install of Ubuntu 14.04.2, on Gnome flashback (I believe it's version 3.9.90), using Metacity (compositing enabled), and I have 1 screen (1920x1080).

[gsemet]

Kinda reproduced. I've installed gnome-fallback on ubuntu 15.04 and have the following issues:
(gnome fallback with compiz:)

• hotkey only work when mouse is hover the main bar
• full height is not taken into account

(gnome flashback with metacity):

• no problem, works great!

[ghost]

That's odd. It doesn't bother me, I just figured I'd report it to be safe =P

[gsemet]

what do you mean by "compositing enabled" ?

[gsemet]

what do you mean by "compositing enabled" ?

[ghost]

You can make metacity look/act like Compiz by enabling compositing in the dconf-editor.
If the dconf key "org>gnome>metacity>compositing-manager" is set to true, it enables true transparency, as well as some other features of compiz.

[ghost]

Disabling compositing does not fix the issue.

[gsemet]

ok i 'll check what i can do with what i have reproduced...

[Vizzard]

I have this on Ubuntu 15.04 (Unity) with Guake 0.7.2 (laptop with one screen).
Changing guake-0.7.2/src/guake/guake_app.py line 871:
window_rect.width = window_rect.width - unity_dock
like this by removing "- unity_dock":
window_rect.width = window_rect.width
and running 'dev.sh --reinstall' and 'dev.sh --install' fixed issue for me.
Looks like 'window_rect.width' already has correct value because guake is full width when launcher is hidden and when launcher is visible it also has correct size (100% screen width minus launcher width). It's working even with different launcher size set (both smaller and larger than default).
Will check later how it will work on my dual monitor PC because I think issues for that configuration are related to this piece of code.
Stibbons, I know you don't have dual monitor configuration. I would like to help but I don't know how exactly. I can test guake versions on my PC with two screens. Just let me know if you need something.

[Vizzard]

On Ubuntu 15.04 (Unity) with Guake 0.7.2 (PC with two monitors, different resolution):
This edit that fixed issue for one monitor environment breaks guake in multimonitor env.
Now guake shows up on primary screen with correct 100% width but having mouse on second screen gives me smaller guake (i suppose smaller monitor resolution minus upper bar) but on primary monitor touching right side of the primary screen, where it connects to smaller screen.

Don't know if it helps because I broke the code and I don't expect it to work. Maybe it will give you some hints. Anyways, this is a quick fix for single screen env or someone who is using guake on one monitor only.

[Vizzard]

I also found that changing guake-0.7.2/src/guake/guake_app.py on line 861 (leaving line 871 original) and removing hard coded '+ 17' gives behaviour like described in my previous comments.
When I change 17 to 1 however, I have almost desired functionality: (almost) no gap regardless of Launcher auto-hide setting and guake shows up on screen with mouse.
I know this gap on second screen is an alignment issue ( #395 and #422 ) because my fix works for me as I have 100% height and width set but when i change it to less than that then alignment is ok (centered) on primary screen and aligned to the left side on second monitor (always, even if horizontal alignment is set to 'right').

[hailwood]

Issue still present on Ubuntu 16.04

Matt

[ashtonmeuser]

:+1:

[MasterEric]

+1, if the Unity Launcher is locked to the bottom instead of the side it has a gap.

In guake_app.py on line 990, make the check if unity_hide != 1 also check whether the unity launcher is locked to the side or the bottom.

[river06]

+1 Issue still exists for Ubuntu 16.04 and Guake 0.8.4

[m3adow]

Same for 16.04 and 0.8.5.1 using Unity.

My main desktop (1920x1080) is working fine.

But my second screen (1280x1024) isn't filled 100%.

[kiview]

I have the same problems as @m3adow and I think it seems to occur on my displays without the unity launcher.

[hailwood]

This now opens full width on my first and second monitor, it however refused to open on my third monitor (right hand side) and instead opens on the second.

[ghost]

Using Unity Tweak Tool in Ubuntu 16.04 and changing the location of launcher from left to bottom is what is causing the problem for me. The bigger icons size I have, the bigger the gap.

[josefnorlin]

Using Unity Tweak Tool in Ubuntu 16.04 and changing the location of launcher from left to bottom is what is causing the problem for me. The bigger icons size I have, the bigger the gap.

[gsemet]

unfortunately I dont have time to work on this currently :( you may want to give a try to hack the function that compute the screen size on your system, it is is python and not so complex to deal with. Just that there are so many different possible screen combination I cannot reproduce here :(

[Vizzard]

Happy to report that I don't have this issue on fresh install of Ubuntu 16.10 :)
Full height and full width on both screens (Launcher only on one, default left position).

[bkach]

This is still a problem for me, and i also think it has to do with the unity tweak tool!

[krassowski]

This problem pertains to Ubuntu (18.04) with Gnome session too so I doubt it is Unity-specific issue.

[krassowski]

I have two monitors: 1024x800 (built-in) and 1680x1050 (external). I configured guake to use 50% of width and height. I have the bigger monitor set as external monitor.
But on BOTH screens it uses 512x400 (despite being shown on the screen where my mouse is placed).

So I run the guake in debug mode to see what screen, width and height is used in set_final_window_rect and indeed it showed values of my built-in monitor.

I tried setting the monitor on which the guake should show up using display-n setting. Funny enough, whichever option I choose, the guake always shows up always there, where my mouse is currently placed.

I've been digging for a while and I think I found one of culprits: Wayland. Here are some symptoms:

• window.move() does not move top-level window reliably
• get_pointer() does not return absolute position (but relative to the window) and only if the pointer is inside of the guake window
• there is no global positioning, only relative.

I also got a workaround working for me: https://github.com/Guake/guake/commit/d83af78162167f41daedd3ce0a976334b996399e - @gsemet, what do you think about it?

What substantial is that the fix should work also for the users of X11, though some adjustments would be needed (I assumed that I do not need to handle cases other than "show mouse display" as I did not find a way to convince Wayland to use other displays).