Guake: ctrl + shift + w, closing, and exit cmd

[ghost]

Similar to #769, #548 -

side note: running "exit" does not close tab (just sits there)

open two tabs, write a sentence in one (don't press enter), close the other tab, and it'll delete the last word in the sentence.

[ghost]

Yep, same here.

[aichingm]

I'm having trouble to reproduce this issue. exit is working too.

what versions are you guys using?

[ghost]

guake 3.0.5
bash 4.4.19
ubuntu 18.04 (was linux mint at the time of the bug)

[ghost]

have two terminals open and type exit on one of them.

[rhwendt]

ctrl + shift + w not working on fresh antergos install running in X11

Name : guake
Version : 3.4.0-1
Shell: zsh 5.7
OS: Antergos Linux x86_64
Kernel: 4.20.6-arch1-1-ARCH

edit: looks like the super + x does close the tab

[tallanvor]

Has same problem with tab closing

Name : guake
Version : 3.4.0
Shell: bash 5.0.0
OS: Antergos Linux x86_64
Kernel: 4.20.8-arch1-1-ARCH

P.S. Installation not fresh, but global updated

[Mayurifag]

archlinux, latest guake + cinnamon, default settings ctrl+shift+w doesn't close tab

[ghost]

would it be helpful to split this into separate bugs?

1. exit cmd and then trying to issue the ctrl/shift/w exit shortcut
2. exit cmd and then trying to issue ctrl shift q exit shortcut
3. exit cmd and trying to create a new tab (Within that dead tab)
4. word-deletion across multiple tabs when deleting a tab

I realize it might be keyboard shortcuts, but does the program have a way to respond to a dead tab if there's no bash to send keyboard shortcuts to (if you see where I'm going with this?)

as far as word deletion, maybe it could be keyboard shortcuts and that's just a way to delete chars?

:/ puzzled.

[ghost]

Interestingly, the word-deletion appears to be /wherever the cursor was/ in the sentence of the tab you arrive at, when closing one.

[Goutte]

Confirming this bug is still rocking on guake 3.4.0 (from Kubuntu 19.04)

Workarounds: Meta+X or Ctrl+D, but muscle memory is protesting.

[mlouielu]

@Goutte Could you run with latest version of guake from source code and test it again?

[Goutte]

Thanks @mlouielu for the handy link to the doc!
The bootstrap script makes it easy to install from source.

I can confirm that with the latest master, closing with Ctrl+Shift+W works as expected!

[gsemet]

cool :) so we can close this ticket?

[Goutte]

@gsemet The collision between Ctrl+Shift+W (close tab) and Ctrl+W (delete last word) is still happening. Closing a tab is going to delete the last word in the tab getting the focus.

It's a minor bug, but it's still not the expected behavior.

[mlouielu]

@Goutte I just reproduce it on master HEAD

reproduce:

1. open one tab, type foo bar
2. open another tab, then Ctrl+Shift+W on it
3. re-focus to first tab, but the word last to foo only.

[mlouielu]

Let me generalize this issue: after then tab get close, re-focus tab will get the keypress event:

• 1 tab: 0x55b95ddcd310
• 2 tab: 0x55b95ed74170

When doing Ctrl + Shift + W on 2 tab, the keypress event give us:

<... (guake+terminal+GuakeTerminal at 0x55b95ed74170)>       # 2 tab
Control_L <flags GDK_SHIFT_MASK of type Gdk.ModifierType> <flags 0 of type Gdk.ModifierType>
<..(guake+terminal+GuakeTerminal at 0x55b95ddcd310)>         # 1 tab
W <flags GDK_SHIFT_MASK of type Gdk.ModifierType> <flags GDK_CONTROL_MASK of type Gdk.ModifierType>

That the first tab get the W+Ctrl+Shift for some reason.

Thus we can generalize this issue to, if someone put Ctrl + Shift + a to close-tab, it will then move the cursor to the start of the line (since Ctrl + a will move cursor to start of the line)

[mlouielu]

This issue was not found at terminator or tilix, so it should able be fixed on guake. If anyone want to help on this issue, I can take some help on it. (Just did the small try, but I got no time for this issue at this moment)

[mlouielu]

NOTE: this didn't affect on the split terminal (e.g. close terminal set to Ctrl+Shift+W then do the same thing in split terminal)

[libook]

@mlouielu Hi, is there a version released? Wish I can see it solved on Arch Linux. Thanks!

[mlouielu]

@libook Hi there, this bug isn't fixed so you will still affect by it. If you want to help it, I can give you some advise on this, cheers.

[libook]

@mlouielu I can wait for release. Thanks for your replying!

[zenmasterjobo]

Hey I am going to give this a shot at fixing it, I have not worked on this code base before - but will open a PR if I get anywhere, in the mean time, any advice or tips on where I should start looking would be super appreciated @mlouielu :)

[mlouielu]

@zenmasterjobo Great, would you like to take a look into the build from source and test if you can run it.

Then take a look into running GTK+ applications to see how to use the debug infra for GTK+ application. (e.g. GTK_DEBUG=interactive make run)

Since is a while, I don't sure where this bug locate from, but you can start from terminal.py:GuakeTerminal to check how the hotkey works.

[zenmasterjobo]

@mlouielu Hey, thanks for the information and pointing me in a good direction

After going through the 'build from source' link and not having any issues I then followed this link: https://guake.readthedocs.io/en/latest/contributing/dev_env.html

and pretty much no matter how I install - when I run make run I get this error ModuleNotFoundError: No module named 'gi'

have you gotten this error before? Any idea what this is indicative of?

Thanks for your help!

[gkochyli]

Hi, I want to give this a shot. I got familiar with the code and tried some stuff with no success.I would like some tips as to how this should be implemented. Thanks