Guake: Tabs bar size incorrect on hidpi screen

[FallingSnow]

I have a 4k display and the tabs only show about half the font.

[gsemet]

Thanks for the report. Can you start guake through a terminal and copy paste the logs ?

[FallingSnow]

$ guake

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.

(guake:3161): libglade-WARNING **: unknown attribute `swapped' for <signal>.
INFO:guake.guake_app:Logging configuration complete
/usr/lib/python2.7/site-packages/guake/guake_app.py:1785: GtkWarning: gtk_box_pac
k: assertion 'child->parent == NULL' failed
  self.mainframe.pack_start(self.notebook, expand=True, fill=True, padding=0)
/usr/lib/python2.7/site-packages/guake/guake_app.py:825: GtkWarning: IA__gtk_wind
ow_set_type_hint: assertion '!gtk_widget_get_mapped (GTK_WIDGET (window))' failed
  self.window.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_DOCK)
/usr/lib/python2.7/site-packages/guake/guake_app.py:826: GtkWarning: IA__gtk_wind
ow_set_type_hint: assertion '!gtk_widget_get_mapped (GTK_WIDGET (window))' failed
  self.window.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_NORMAL)

Like so?

[gazambuja]

Same problem here (Dell XPS 13 9343) any other test to do?

$ guake
(guake:21508): libglade-WARNING **: unknown attribute 'swapped' for <signal>.
(guake:21508): libglade-WARNING **: unknown attribute 'swapped' for <signal>.
(guake:21508): libglade-WARNING **: unknown attribute 'swapped' for <signal>.
(guake:21508): libglade-WARNING **: unknown attribute 'swapped' for <signal>.

INFO:guake.guake_app:Logging configuration complete

/usr/lib/python2.7/dist-packages/guake/guake_app.py:1749: GtkWarning: gtk_box_pack: assertion 'child->parent == NULL' failed
  self.mainframe.pack_start(self.notebook, expand=True, fill=True, padding=0)

/usr/lib/python2.7/dist-packages/guake/guake_app.py:820: GtkWarning: IA__gtk_window_set_type_hint: assertion '!gtk_widget_get_mapped (GTK_WIDGET (window))' failed
  self.window.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_DOCK)

/usr/lib/python2.7/dist-packages/guake/guake_app.py:821: GtkWarning: IA__gtk_window_set_type_hint: assertion '!gtk_widget_get_mapped (GTK_WIDGET (window))' failed
  self.window.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_NORMAL) 



$ xwininfo 
xwininfo: Window id: 0x1800019 "Guake!"

  Absolute upper-left X:  0
  Absolute upper-left Y:  55
  Relative upper-left X:  0
  Relative upper-left Y:  55
  Width: 3200
  Height: 702
  Depth: 32
  Visual: 0x8d
  Visual Class: TrueColor
  Border width: 0
  Class: InputOutput
  Colormap: 0x1800003 (not installed)
  Bit Gravity State: NorthWestGravity
  Window Gravity State: NorthWestGravity
  Backing Store State: NotUseful
  Save Under State: no
  Map State: IsViewable
  Override Redirect State: no
  Corners:  +0+55  -0+55  -0-1043  +0-1043
  -geometry 3200x702+0+55

[boscowitch]

Same Problem on a Lenovo P50 with a 4k screen... I guess there is some scaling of the fonts underway in gnome and some apps also scale the buttons ect. but even the ones that do scale have too small icons most of the time.

[gsemet]

sadly i dont have a 4k screen to test. But I also have an issue with HEAD, the size is wrong on the right of the screen. Look like old version of gtk does give the right screen size :(

[boscowitch]

Well to me it looks like GTK is doing the Button Size right the width always fits and the heigth looks also good because the borders go out of the "toolbar" the only thing that is not size fitted is the heith of the "toolbar" where the button is placed on. Either it is really a gtk bug, or it really is just that the size to content calculation come with a later event after the size of the "toolbar" is calculated. So I guess maybe the title of the button is set later than the toolbar ? Or Maybe the toolbar is missing some size propagation flag fit to content or sth... well I forgot most of the correct names been a while sinde I coded with gtk, but I have some vague memorys that would fit such a explanation.
. I run archlinux so my gtk should be pretty up to date since it's the most up to date distro i know here the packet version I have installed: gtk2 2.24.30-1 and gtk3 3.20.3-1

[boscowitch]

I played around a bit with the code... seems like GTK fails to adjust the size because RadioButtons are used with changed propertie, when i uncommented or changed bnt.set_property('draw-indicator', False) to True, size adjustment seems to work better ... unfortunately it looks ugly with radio buttons in front ;)

I'm wondering if this problem also exists when using gtk3 ... but i couldnt get it running with it yet guess gtk3 ist still in erly phase ?
Another question does the notebook not have its own tab buttons ? And why are they not used do they have some major drawback ? I guess they maybe would scale better.

I tired to play around with more propertys regarding resize ect. but all no effect. if i force a resize on the button it will be lager but the notebooks bar wont resize so I only see the upper border of the buton and the text vanishes more I also hoped that the notebook would aquire more size if I also set the label text of the tab but unforunately its not so easy, after some googleing I found this: http://coding.debuntu.org/python-gtk-how-customize-size-button-notebook-tab-label seems like its more work to fit the size with a custom class

[ehartford]

I had this issue when I changed the font size from the 10 point system default to a larger monofur powerline, the tab bar did not increase to accommodate the font size increase.

[ElvisPresly]

confirm

[omidraha]

I have the same issue:

[kmxm]

Here is a solution. I found out that height of the bar is hard-coded into glade UI descriptor file. I have removed height request letting gtk automatically set height accordingly to the content. So replace /ush/share/guake/*.glade files with attached.

guake.zip

[ehartford]

@kmxm these files are quite different from the ones currently in the repo.
If you could possibly do a PR with minimal changes to fix the height?

[gsemet]

I let you deal with this, I mainly focus on guake 3 (gtk3 port) that requires full rewrite

[philmander]

To follow up on @kmxm 's comment, I just removed the line containing: <property name="height_request">10</property> in /usr/share/guake/guake.glade

This fixed the problem for me. I'm reluctant to make a PR because I have no idea if this would have any undesired consequences on other systems. I'm using a Dell XPS HiDPI screen with Ubuntu 16.04/Unity

[omidraha]

@philmander , Worked for me on the Kubuntu 16.04.3, 4k screen.

[FallingSnow]

This issue seems to resolved in version 0.8.9. Can anyone else confirm?

[olatov]

Started happening on the latest master to me again.
Seems to be caused by 29f6f328e73594d7e2d3706f81a03a24998c48a7

[gsemet]

Can someone test with latest Guake 3 ?

[FallingSnow]

Seems to be fixed now.