Godot: Remove Patch9Frame

[robertdhernandez]

Patch9Frame and a Panel with a StyleBoxTexture are effectively the same thing, so I think it should be removed since they're the same thing. I find it redundant to have two things that do the same thing, and only makes maintaining them more of a hassle.

[blurymind]

doesnt one take more effort to set up than the other?

Also many developers know what patch9frame means, the word "9 patch" is used in other game engines and people know what it does.
Getting the same functionality in godot via two nodes is not something many people coming from other engines will easily figure out. That is one con I can think of - using two nodes in a specific conguration vs using one specialized node seems like a workaround and doesnt allow for forking to add specific patch9 features

Those are the pros in keeping patch9frame node imo
What are the pros and cons of the two approaches?

[bojidar-bg]

Adding to the 3.0 milestone so that it isn't forgotten.

[reduz]

Theres is NinePatchRect in 3.0

On Tue, Jun 27, 2017 at 5:54 AM, Bojidar Marinov [e-mail]
wrote:

Adding to the 3.0 milestone so that it isn't forgotten.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/8212#issuecomment-311296060,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2x0ibAmYDWvYhtPE0hS8gJ1ZjRqtks5sIMNAgaJpZM4MvMQW
.

[toger5]

what about making the NinePatchRect a node2D? I haven't thought a lot about it yet, but than it would be like other node2d and simpler to use for people who mostly use node2d for there games. (controls are strong with GUI but not that often used in games so ppl might be more familiar with the concept of scaling instead of rect_size)

[reduz]

Well, it's a GUI control. We could make a NinePatchSprite if you want

On Wed, Jun 28, 2017 at 6:45 AM, Timo [e-mail] wrote:

what about making the NinePatchRect a node2D? I haven't thought a lot
about it yet, but than it would be have like other 2d nodes and simpler to
use for people who mostly use node2d for there games. (controls are strong
with GUI but not that often used in games so ppl might be more familiar
with the concept of scaling instead of rect_size)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/8212#issuecomment-311611051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z20RpFDK_xUnsz9E8nvy-WNooqOh7ks5sIiC8gaJpZM4MvMQW
.

[toger5]

what I'm proposing is removing the ninePatchControl and adding the 9patchSprite.
Ppl who do Gui know about themes, are familiar how to use them and don't mind the extra click on: new styleBoxTexture.
ppl who are just searching for a 9patch node, have everything they need with a sprite.

[reduz]

It doesnt make sense to remove it from GUI, as a lot of people asked for it
in the past. It's in line with TextureButton, TextureProgress and the like
for simpler UIs. It's also a very small class, no harm in having both.

On Wed, Jun 28, 2017 at 7:57 AM, Timo [e-mail] wrote:

what I'm proposing is removing the ninePatchControl and adding the
9patchSprite.
Ppl who do Gui know about themes, are familiar how to use them and don't
mind the extra click on: new styleBoxTexture.
ppl who are just searching for a 9patch node, have everything they need
with a sprite.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/8212#issuecomment-311626692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z29hZsi0wnuu937aYB5YqAk8vTg_oks5sIjGFgaJpZM4MvMQW
.

[reduz]

closing this. If anyone wants a nine patch sprite, just do a PR..but honestly current control should work fine for 2D anyway and is easier to edit.