Godot-docs: Update readthedocs-sphinx-search

Created on 1 Sep 2020  路  3Comments  路  Source: godotengine/godot-docs

Looks like you are using an old version of the extension https://github.com/godotengine/godot-docs/blob/70e9184552ab9cf83a2654650210b9674980e3af/requirements.txt#L13

We updated the endpoint used by the search extension, so old versions will stop working soon. Please use the new version of the extension https://github.com/readthedocs/readthedocs-sphinx-search (we have releases in pypi now ;))

bug

Most helpful comment

Also, please keep in mind the extension is still in beta, so till 1.0 we may be breaking some stuff. But hopefully the API isn't going to change (the html structure, css classes and js functions may change). Anyway, I'll let you know in case something breaking happens

All 3 comments

Thank you for the heads up. @Calinou is this something you would know how to update?

We need to update https://github.com/godotengine/godot-docs/blob/master/requirements.txt to the appropriate hash, and then deploy. Or, I guess, since they are using pypi now, we can move away from Git URL at the same time, and pin a version.

And speaking of this extension, readthedocs/readthedocs-sphinx-search#48 has been fixed and we can probably clean up on our end a bit.

Also, please keep in mind the extension is still in beta, so till 1.0 we may be breaking some stuff. But hopefully the API isn't going to change (the html structure, css classes and js functions may change). Anyway, I'll let you know in case something breaking happens

Was this page helpful?
0 / 5 - 0 ratings

Related issues

clayjohn picture clayjohn  路  4Comments

youreperfect picture youreperfect  路  3Comments

puthre picture puthre  路  4Comments

touilleMan picture touilleMan  路  4Comments

eon-s picture eon-s  路  3Comments