Givewp: Disconnecting a single site from Stripe should not require disconnecting all sites on the same account

[henryholtgeerts]

User Story

As an admin of several sites, I want the ability to disconnect a single site from Stripe without having to disconnect all of my previously connected sites that are connected to my same Stripe account.

Details

Currently, disconnecting a connected Stripe account from the GiveWP plugin revokes permissions for GiveWP as an "Authorized applications" on that Stripe account. This is destructive behaviour that breaks other connections to GiveWP on that account.

Expected Behavior

Disconnecting a connect Stripe account from the GiveWP plugin should not revoke permissions for GiveWP as an "Authorized applications" on that Stripe account so that other connected sites continue to operate as expected.

Steps to Reproduce

1. Go to Settings -> Payment Gateways -> Stripe -> Manage Accounts.
2. Click "Connect with Stripe" and complete the connect process.
3. Go to Settings -> Authorized Applications in the Stripe dashboard of the connected account.
4. View GiveWP as an Authorized Application.
5. Go to Settings -> Payment Gateways -> Stripe -> Manage Accounts.
6. Click "Disconnect" to remove a connected account.
7. Go to Settings -> Authorized Applications in the Stripe dashboard of the connected account.
8. View GiveWP is no longer an Authorized Application.

Visuals

GiveWP connected Stripe accounts

Stripe authorized applications

Additional Context

The Stripe add-on includes the option to connect a site via key.

Acceptance Criteria

• [x] A Stripe account can be disconnected form the site.
• [x] Disconnecting an account does not revoke GiveWP as an Authorized Application.
• [ ] Manually connected Stripe accounts (Stripe add-on) can still be disconnected.

[canny[bot]]

This issue has been linked to a Canny post: Stripe Single-site Disconnect :tada:

[kevinwhoffman]

@henryholtgeerts @kjohnson There was a pull request created, however it didn't seem to fully address the issue. I think this is in part due to an issue that lacked detail.

When work continues, on this issue, please take the time to complete the issue template and acceptance criteria. Have @Benunc review the acceptance criteria to ensure we are developing a solution that fully addresses the problem.