Givewp: Give Importer: Delete Imported Donations doesn't Delete Users created during import

[mathetos]

Issue Overview

Using the Delete Imported Donations tool, found in "Donations > Tools > Data", doesn't delete the WordPress users that were created by the donations import. Donors and donations are deleted correctly, but the WordPress users are not.

Expected Behavior

Either, everything is deleted -- donations, donors, and WP users -- or we need to provide additional options so admins can choose the behavior they want.

Current Behavior

The WordPress users are not deleted.

Steps to Reproduce (for bugs)

1. Do an import
2. Confirm that new WordPress users were added
3. Use the "Delete Imported Donors and Donations" tool.
4. Confirm that the WordPress users were not deleted.

[raftaar1191]

@mathetos @DevinWalker

I Wp User is not getting deleted intentionally.

If want to delete the WP users as well let me know?

[mathetos]

I believe that if the WP Users were created by the import, and the admin chooses to use the "Delete Imported Data" that the expected result would be that the WP Users are deleted as well. We could add an optional checkmark when that tool is selected from the dropdown to enable WP Users as well, but as-is the result is unexpected.

[ravinderk]

@mehul is able to reproduce this issue.

[raftaar1191]

@mehul0810

Please update me if any of the point I have to forget

Point to be check
1> Donation Status not getting properly imported
2> Progress Bar not working properly when deleting the data from the Tools Tab
3> Some Donor not getting deleted
4> Some WP user are not getting deleted
5> Some Donation not getting deleted as well

[ravinderk]

@raftaar1191 told me that this issue only occurring with exported csv from Give otherwise working fine, So bumping up this one

[raftaar1191]

Working on this ?

[raftaar1191]

@mehul0810

Just had a look into this by Importing and deleting the Import donation to with Code from the branch https://github.com/WordImpress/Give/tree/release/1.8.17

I only find one issue is:
1> Progress Bar not working properly when deleting the data from the Tools Tab

Can you please have a look into this an let me know if you are still facing the issues again?

[raftaar1191]

https://github.com/WordImpress/Give/pull/2270/ PR is also affecting https://github.com/WordImpress/Give/issues/2062 issues

[raftaar1191]

@mathetos @mehul0810

Please have a look into this video I have update some code
Video link: http://youtu.be/Oj6O7GpPfb8?hd=1

Notes: This Code is being tested with the branch 1.8.17 https://github.com/WordImpress/Give/tree/release/1.8.17

WordPress Environment

### WordPress Environment ###

Home URL: http://localgive.dev
Site URL: http://localgive.dev
WP Version: 4.8.3
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

### Server Environment ###

Hosting Provider: DBH: localhost, SRV: localgive.dev
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.10 (Debian)
PHP Version: 7.1.4
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

### Give Configuration ###

Give Version: 1.8.17
Upgraded From: 1.8.17
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://localgive.dev/donation-confirmation/
Failure Page: http://localgive.dev/donation-failed/
Donation History Page: http://localgive.dev/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Admin Email Notifications: Enabled
Donor Email Access: Enabled

### Session Configuration ###

Give Use Sessions: Enabled
Session: Disabled

### Active Give Add-ons ###


### Other Active Plugins ###

Give Cutom Plugin: by  –
Query Monitor: by John Blackbourn – 2.17.0

### Inactive Plugins ###

Debug Bar Console: by koopersmith – 0.3
Debug Bar Cron: by Zack Tollman, Helen Hou-Sandi – 0.1.2
Debug Bar Extender: by Thorsten Ott, Automattic – 0.5
Developer: by Automattic – 1.2.6
Duplicate Post: by Enrico Battocchi – 3.2
Give - 2Checkout Gateway: by WordImpress – 1.0.2
Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0
Give - Authorize.net Gateway: by WordImpress – 1.3
Give - CCAvenue Gateway: by WordImpress – 1.0
Give - Currency Switcher: by WordImpress – 1.0.0
Give - Email Reports: by WordImpress – 1.0.1
Give - Fee Recovery: by WordImpress – 1.3
Give - Form Field Manager: by WordImpress – 1.2.4
Give - Gift Aid: by WordImpress – 1.0.0
Give - Manual Donations: by WordImpress – 1.2
Give - PayPal Pro Gateway: by WordImpress – 1.1.4
Give - PDF Receipts: by WordImpress – 2.0.7
Give - PDF Receipts: by WordImpress – 2.0.7
Give - Per Form Emails: by WordImpress – 1.0.2
Give - Razorpay: by WordImpress – 1.1.0
Give - Recurring Donations: by WordImpress – 1.4
Give - Stripe Gateway: by WordImpress – 1.5
Give - Tributes: by WordImpress – 1.2
Give - WePay Gateway: by WordImpress – 1.3.1
Give - WP All Import Addon: by Ben Meredith – 1.0
Give - Zapier: by WordImpress – 1.1.2
Give to ZBS CRM Connector: by https://zerobscrm.com – 1.0.1
Hookr: by @explodybits – 1.0.0 (beta)
Loco Translate: by Tim Whitlock – 2.0.16
Log Deprecated Notices: by Andrew Nacin – 0.4
Log Viewer: by Markus Fischbacher – 14.05.04
Redis Object Cache: by Till Krüss – 1.3.5
Rewrite Rules Inspector: by Daniel Bachhuber, Automattic – 1.2.1
rtMedia for WordPress, BuddyPress and bbPress: by rtCamp – 4.4.4
UpdraftPlus - Backup/Restore: by UpdraftPlus.Com, DavidAnderson – 1.13.12
User Switching: by John Blackbourn – 1.3.0
WooCommerce: by Automattic – 3.2.3
WordPress Importer: by wordpressdotorg – 0.6.3
WP Downgrade | Specific Core Version: by Reisetiger – 1.1.4
WP Rollback: by WordImpress – 1.5
WP Super Cache - Clear all cache: by Apasionados.es – 1.4

### Active MU Plugins ###

Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0

### Theme ###

Name: Twenty Sixteen
Version: 1.3
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

[mehul0810]

@raftaar1191 I've tested each and every step with release 1.8.17 and found that all the mentioned points (https://github.com/WordImpress/Give/issues/2062#issuecomment-336138345) are working fine except one.
I've ignored point Progress Bar not working properly when deleting the data from the Tools Tab as discussed over call and you will be creating a separate issue for this point.

[raftaar1191]

Thanks, @mehul0810 for testing it. yes will create a separate issue for that

@ravinderk Can you please closing this Issue