Gitmoji: Add, update, or remove

Created on 20 Sep 2020  ·  12Comments  ·  Source: carloscuesta/gitmoji

Hey! I was wondering if we could add "remove" to all the sentence description that currently have "Add or update"? For instance, consider the 👥 gitmoji. It currently says "Add or update contributor(s)." What if you want to remove a contributor? Or the 🥚gitmoji. It currently says "Add or update an easter egg." What if you want to remove an easter egg?

discussion

Most helpful comment

Lets say that a removal is kind of an update 😅

All 12 comments

Lets say that a removal is kind of an update 😅

@johannchopin @carloscuesta I'm inclined to agree with you guys that a removal or deletion counts as an update but, upon further reflection, I still think that we should consider adding this explicitly in the descriptions. Why? Because one of the most popular API paradigms—CRUD—which almost every front-end and back-end developer is familiar with, makes a distinction between the two.

In fact, I'm changing my proposal to make everything "Create, update, or delete" instead of "Add, update, or remove" just to make explicit reference to CRUD. Could we even make some gitmojis consist of two emojis? The first to describe the type of operation and the second to describe the operation. For example:

  • 🟢: Create
  • 🔵: Update
  • 🔴: Remove

Then for the compiled files or packages, we would have:

  • 🟢📦: Create compiled files or packages
  • 🔵📦: Update compiled files or packages
  • 🔴📦: Remove compiled files or packages

I understand that this would dramatically increase the number of gitmojis but I don't think it makes them cumbersome to work with. When I search for gitmojis, I look for keywords like "documentation" or "tests" which would immediately turn up all three variants described above. Let me know what you guys think!

Gitmoji should stay light.

Following CRUD, you forget the action READ.

@KaKi87 Yeah, maybe the extra gitmojis would prove to be cumbersome. I still stand behind my proposal of changing the descriptions, though.

@johannchopin READ is the one operation that does not modify state, which renders it useless for commit messages.

READ is the one operation that does not modify state, which renders it useless for commit messages

I think that's enough to tell that CRUD is really data-oriented while code is not about data.

What about we remove those verbs? then we would end up with just the context :thinking:

A verb is still required when there is a distinction between add and remove anyway.

I still stand behind my proposal to make everything "Create, update, or delete." Requesting repository owner @carloscuesta to chime in to make the final decision.

Just to state my position here, I prefer keeping just the Add or update ... as it is less verbose.

@carloscuesta Can you weight in here so we can close this issue? I'm okay either way, but I do prefer following CRUD semantics.

Sorry for the late reply! I would like to keep it less verbose as @vhoyer says

Thanks for opening the issue ❤️

Was this page helpful?
0 / 5 - 0 ratings