Github: Prompt to unlock login keyring on startup

[Rua]

Steps to Reproduce

1. Have automatic login enabled in the OS
2. Open a project that's on Github
3. Get prompted to unlock the keyring
4. Click cancel and continue as normal.

Expected behavior:

It shouldn't ask for the keyring password until it's actually going to do something that requires it, such as pushing changes to Github or opening a pull request. Merely opening a project shouldn't trigger it. The fact that I'm able to click cancel and then continue my work as always shows that the keyring isn't really needed for anything crucial at that point.

Reproduces how often:

100%

Versions

Atom : 1.41.0
Electron: 4.2.7
Chrome : 69.0.3497.128
Node : 10.11.0

OS: Linux Mint 19.3 Cinnamon

[ozfox]

My thoughts exactly. Nothing to add.

[ferares]

I have an issue that might be related to this.
When Atom asks me to unlock my keyring and I refuse everything works as expected until I open further Atom instances, those new instances won't be able to open files, they will only show me the tree view but clicking on a file only selects them and does not display them. Closing all instances of Atom and reopening them again does not fix the issue and the prompt to unlock the keyring does not reappear unless I reboot my system.

Versions

Atom: 1.50.0 x64
Electron: 5.0.13
Chrome: 73.0.3683.121
Node: v12.0.0

OS: Manjaro Linux.

[hartmut]

The same here with the following

Versions

Atom: 1.53.0 x64
Electron: 6.1.12
Chrome: 76.0.3809.146
Node: v12.4.0
OS: Ubuntu 20.04.1 LTS

One more detail: the user is logged on automatically so it could be that the keyring isn't opened without the Ubuntu log on password

[jtassarotti]

The issue is even worse for me, in that Atom will not allow locally saving any files in that GitHub project if the unlock prompt is cancelled, even in safe mode.

Versions

Atom: 1.54.0
Electron: 6.1.12
Chrome: 76.0.3809.146
Node: 12.4.0
OS: Ubuntu 20.04.2 LTS

[jNullj]

i seem to have similar issue

Atom : 1.54.0
Electron: 6.1.12
Chrome : 76.0.3809.146
Node : 12.4.0
OS: Archlinux

i have other issues (idk if its related), when closing the last text based file (not image) i can not open new ones in the gui, including safe mode, until i open in new window.

Also i can not commit, and sometimes can't even look at stages changes or stage/unstage changes. sometimes they get staged without updating the gui (i can only see it after restarting atom)

[javiqm12]

Same here!

Atom 1.55.0
Electron 6.1.12
Chrome 76.0.3809.146
Node v12.4.0

[jNullj]

i seem to have similar issue

Atom : 1.54.0
Electron: 6.1.12
Chrome : 76.0.3809.146
Node : 12.4.0
OS: Archlinux

i have other issues (idk if its related), when closing the last text based file (not image) i can not open new ones in the gui, including safe mode, until i open in new window.

Also i can not commit, and sometimes can't even look at stages changes or stage/unstage changes. sometimes they get staged without updating the gui (i can only see it after restarting atom)

since i updated to 1.55.0 i don't get keyring prompt anymore (atleast not so far)

[Jamie-SA]

Wow, I finally found a thread that matches my problems (can't open files, can't save files if I get them open). I've been searching off an on for a couple of months looking for someone else with the problem and hopefully a solution.

I don't use OS keyrings and I definitely don't want to be forced to use one by my editor.

I also found this post which resulted in a solution. I moved ~/.local/share/keyrings/login.keyring and when I started atom again, this time I paid attention (it could have been asking before but I never really read the text in the three dialogs that would pop up) and it asked to create a default keyring which I did with no password. It warned about saving passwords in plain text but I am OK with that because I don't put passwords into it which is why I would just click cancel without paying attention before.

It seems to be working at the moment. But why would a text editor require me to use a keyring to function properly?

Atom : 1.56.0
Electron: 9.4.4
Chrome : 83.0.4103.122
Node : 12.14.1
OS: Linux Mint 20.1