Github: Uncaught TypeError: author.getFullName is not a function

[move[bot]]

@cam-perry commented on Aug 22, 2018, 10:06 PM UTC:

All done using the Git Window:

1. Create a commit with a Co-Author
2. Undo that commit
3. Click to add a Co-Author again

Atom: 1.29.0 x64
Electron: 2.0.5
OS: Mac OS X 10.13.5
Thrown From: Atom Core

Stack Trace

Uncaught TypeError: author.getFullName is not a function

At /Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:211

TypeError: author.getFullName is not a function
    at renderCoAuthorValue (/Applications/Atom.app/Contents/Resources/app/node_modules/github/lib/views/commit-view.js:533:35)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/react-select/lib/Select.js:961:13
    at Array.map (<anonymous>)
    at Select.renderValue (/Applications/Atom.app/Contents/Resources/app/node_modules/react-select/lib/Select.js:948:29)
    at Select.render (/Applications/Atom.app/Contents/Resources/app/node_modules/react-select/lib/Select.js:1320:18)
    at Gg (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:166:232)
    at Kg (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:179:81)
    at th (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:201:28)
    at uh (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:202:240)
    at Rh (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:211:404)
    at Uh (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:210:284)
    at Sh (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:210:119)
    at interactiveUpdates (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:225:404)
    at Jd (/Applications/Atom.app/Contents/Resources/app/node_modules/react-dom/cjs/react-dom.production.min.js:89:119)

Commands

     -0:42.1.0 application:open (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:19.1.0 core:confirm (span.github-FilePatchListView-path)
     -0:17.2.0 core:select-all (input.hidden-input)
     -0:16 core:backspace (input.hidden-input)

Non-Core Packages

autocomplete-python 1.10.10 
busy-signal 1.4.3 
change-case 0.6.5 
duplicate-line-or-selection 0.9.0 
file-icons 2.1.24 
go-imports 0.1.1 
go-plus 5.8.5 
hyperclick 0.1.5 
intentions 1.1.5 
language-graphql 0.10.1 
linter 2.2.0 
linter-eslint 8.4.1 
linter-ui-default 1.7.1 
prettier-atom 0.55.1 
python-autopep8 0.1.3 
react 0.18.0 
Sublime-Style-Column-Selection 1.7.4 

This issue was moved by rsese from atom/atom#17905.

[annthurium]

thanks @cam-perry for reporting!

I believe this has been fixed in https://github.com/atom/github/pull/1558 - if you are still able to repro in Atom 1.30.0 could you please let me know?

[cam-perry]

Thanks for the reply @annthurium. I'll report again if this is comes up once I update.

[rsese]

Ahhh thanks @annthurium :+1: I could reproduce with 1.29 on macOS 10.12.6 but not with 1.30.0-beta2.

Thanks again for the report @cam-perry and I'll go ahead and close this for now since it's bot-opened 🤖