Git-updater: Gitab updates fails on Private repos

[tdavidrussell]

Due the new security updates (see: https://about.gitlab.com/2018/11/28/security-release-gitlab-11-dot-5-dot-1-released/)

Discussion (issue) https://gitlab.com/gitlab-org/gitlab-ce/issues/54572

None of my Private Repos will update on 3 different sites.

[afragen]

Thanks. It worked yesterday. I generally like GitLab but this seems to have come with no notice.

I’ll try to get a fix out as soon as I find out more information.

[afragen]

@tdavidrussell I’m getting closer to a solution, hopefully by the end of the day. It seems GitLab has changed the manner in which HTTP GET is allowed to access their API. I was already using the APIv4 to do all the individual file GETs, but the repository downloads also significantly changed. It seems that’s the only part broken.

I’ve gotten downloading of release assets, and public repositories working, but that obviously still means this issue hasn’t been fixed. 🙄

[afragen]

@tdavidrussell https://github.com/afragen/github-updater/commit/16519f5bb390b94f7560b4f54998ec2643cdf62d Should fix everything. Please test the latest develop branch and let me know.

[tdavidrussell]

works great, tested on three different sites. single and multisite