Git-updater: On Plugins page active branch message is incorrect

Created on 13 Apr 2017 · 15Comments · Source: afragen/git-updater

Hi,

I changed the branch of a certain plugin, and it downloaded the right branch and the code is updated, but on the plugins page it always says that I'm on master branch.

Source

dbeja

All 15 comments

That's because you don't have the branch header correctly added to the specific branch. If no branch header is present the default is 'master'. GHU gets the branch info from this header.

afragen on 13 Apr 2017

I have included an explanation in the wiki too. https://github.com/afragen/github-updater/wiki/Versions-and-Branches

afragen on 14 Apr 2017

Would it make sense to save the branch name in wp_options when we switch branches and show that information instead?

I think branches are very dynamic, you create a lot of them to create new features and most of the times I think developers won't change that header.

At least for me, when I'm developing a new plugin I'm always updating the code via Branch Switching and it would be interesting to not have to change that header every time I create a new branch. (just a suggestion)

Would it be useful to do a pull request with this or you think it makes more sense to read the branch name always from the header?

Thanks!

dbeja on 11 Jul 2017

I understand the difficulty, especially when you are creating many temporary branches. Let me think about how best to implement this.

afragen on 11 Jul 2017

👍1

@dbeja check out the branch branch. Make sure you refresh your cache after after you switch.

afragen on 12 Jul 2017

The primary drawback is that if you have users test specific branches you can get them back on a different branch by pushing a commit with a different branch header and a version bump. Well you have to do that twice. I don’t think that’s possible any with this change.

afragen on 12 Jul 2017

Hmm we always deploy from a deploy branch so I'm not sure I'd use this feature... but I don't think it would negatively impact my process in any significant way so I'm neutral/in favor of this change.