Gdevelop: Contextual options aren't greyed out when they can't be used

Created on 25 Mar 2019  路  7Comments  路  Source: 4ian/GDevelop

Describe the bug

Right-clicking on a Link event shows "Add Sub-event" although it cannot be used on this event.

To Reproduce

Right-click on a Link event ("Include events from ...").
Choose Add Sub-event.
Nothing happens.

Other details

Windows 10
GD5 b65

All 7 comments

I can look into that :) I added the command there after all

Can you think of other corner cases when something else should be greyed out?

Cool, let me know how it goes :) Events should have a canHaveSubEvents method.

this one is quite simple. Will do a pull tonight

made a fix here
https://github.com/4ian/GDevelop/pull/990

while at it, we shouldnt be able to toggle comments on/off

For comments, you can use isExecutable :) (an event that is not executable is stripped when exported to code, so can't be disabled as it's "already" disabled)

@PascalLadalle this is now fixed in the master branch. Can you try again and if it works as expected for you, close this issue?

Let's close this as it should be fixed for next version :) Can re-open later if for some reason it does not work.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Jose-Moreno picture Jose-Moreno  路  5Comments

Jeje2201 picture Jeje2201  路  5Comments

PascalLadalle picture PascalLadalle  路  3Comments

Bouh picture Bouh  路  4Comments

shadow00dev picture shadow00dev  路  4Comments