Gdevelop: cordova-build shown in the UI could be named Android Export instead

Created on 10 Feb 2020  路  4Comments  路  Source: 4ian/GDevelop

Describe the bug

When you select export Android for get an .APK, in build list we see an cordova-build in progress.

Should be called Android or apk export, for something associate with Android export.
I know you use cordova behind for build the apk and that's why wee see cordova but it can be a source of misunderstood.

Reproduce

Click on
image

Wait and see in build list.
image

Other details

beta 88

馃憣good first issue 馃槫Non optimal UI behavior

Most helpful comment

Yes sure you can @Kalovelo, no need to ask, you're free to start what you want :)
Open source allow to work on what you want, so don't hesitate and when you have an possible fix open your own PR 馃

All 4 comments

馃憢 Hello! 馃憢
Could I work on this issue?

@4ian

Yes sure you can @Kalovelo, no need to ask, you're free to start what you want :)
Open source allow to work on what you want, so don't hesitate and when you have an possible fix open your own PR 馃

Still useful in case you want to do something quite large or want to make sure people are aware you're trying something. But yeah feel free to go ahead! :)

I updated the build title by adding "apk" into parenthesis ( result : "cordova-build(apk)" ).
I changed localhost to gdevelop-app-local but a CORS problem occurred so I had to test it using storybook.
Do you consider the new name change suitable?
I will proceed with the PR as soon as possible!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

blurymind picture blurymind  路  5Comments

RyanNerd picture RyanNerd  路  4Comments

Phenomena3 picture Phenomena3  路  5Comments

giusreds picture giusreds  路  4Comments

ced64k picture ced64k  路  4Comments