Freecodecamp: Challenge is getting accepted without sufficient code.

[akshaynaik404]

Challenge Name

https://www.freecodecamp.org/challenges/convert-json-data-to-html

Issue Description

Challenge is getting accepted without sufficient code.

Browser Information

• Browser Name, Version: Chrome Version 60.0.3112.78 (Official Build) (64-bit)
• Operating System: Ubuntu 16.04.2 LTS
• Mobile, Desktop, or Tablet: Desktop

Your Code

<script>
  $(document).ready(function() {

    $("#getMessage").on("click", function() {
      $.getJSON("/json/cats.json", function(json) {

        var html = "";
        // Only change code below this line.

        console.log(json)        
        json.forEach(function () {

        }); 
        // Only change code above this line.

        $(".message").html(html);
      });
    });
  });
</script>

[dhcodes]

Confirmed. We need to update the current test or add a new one.

[akshaynaik404]

I am a first time contributor, Do you think I can solve it? If yes, Any instructions?

[dhcodes]

@akshaynaik404 probably! Our tests are usually written in Regex. Set up your local instance by following this instructions: https://github.com/FreeCodeCamp/FreeCodeCamp/blob/staging/CONTRIBUTING.md

If you run into questions, ask them here: https://gitter.im/FreeCodeCamp/Contributors

[prtk418]

@akshaynaik404 are you still on it??

[akshaynaik404]

Yes @prtk418 .

[prtk418]

@akshaynaik404 ok

[akshaynaik404]

Is this the right branch, file that I should be looking to modify @dhcodes ?

https://github.com/freeCodeCamp/freeCodeCamp/blob/backup/master/seed/challenges/01-front-end-development-certification/json-apis-and-ajax.json

I can see where the new test should go,
just want to confirm that its the right file.

[vkWeb]

@akshaynaik404 Yes that's the right file.

[ResamVi]

So I allowed myself to work on this as it seems this is open for Hacktoberfest.

I decided not to test whether Object.create was used in the code (as it's hinted in the instructions) because there are multiple ways to solve this (a for-loop as example).

It really is difficult to test accurately but not force someone into a pttern

[raisedadead]

@ResamVi thanks for working on this and fixing the tests.

NOTE
This is still open for a fix on backup/master branch (production site) for any one instrested.

[ahmadabdolsaheb]

@raisedadead i would like to work on this if it is still available?

[jsonkao]

@ahmadabdolsaheb this challenge doesn't exist on beta; I guess it was cut out of the program.

[raisedadead]

Yup, this was removed in beta, but @ahmadabdolsaheb if interested you are welcome to open a PR against the backup/master.

[ahmadabdolsaheb]

@raisedadead done.
@ResamVi thanks for the code.

[BerkeleyTrue]

production is on a feature freeze. Since this change has already been made, this issue is no longer relevant.

Happy Coding