Freecodecamp: Make font size consistent across panes

Created on 1 Aug 2017  路  17Comments  路  Source: freeCodeCamp/freeCodeCamp

Currently the font size is different for each pane.

jquery__target_html_elements_with_selectors_using_jquery___freecodecamp

I checked CodePen and they're using 15 px for all of their editors. JSBin is using 14px. I think 15 px is a good tradeoff between readability and compactness. So we should make all non-header text 15px.

help wanted

Most helpful comment

Can i work on this issue ?
i am a first timer

All 17 comments

@QuincyLarson I agree that 15px if a good size. If you allow, I'd like to do this.

@prateekgoel OK - great! I think you were also working on the "help" button for production, right? That is a higher priority.

@QuincyLarson Thanks. Yes, I'm working on the "help" button for production and it's at the top on my list.

Can i work on this issue ?
i am a first timer

@AbdelghaniTassi Sure - I think most of what will need to be changed will be in the main.css file. You may be able to figure out what classes the different text elements are using by inspecting them in your browser.

@AbdelghaniTassi As @QuincyLarson mentioned, you work on this then. All the best. :+1:

@QuincyLarson @prateekgoel Ok thank you i'll get started on this.

@AbdelghaniTassi Did you get a chance to work on this?

May I contribute?

@prateekgoel i was busy lately i looked in the code and i identified the css classes that should be modified
i will finish it this weekend

@AbdelghaniTassi Awesome - thanks for the update.

@SavSE We would love your help with some of these other help-wanted issues here: https://github.com/FreeCodeCamp/freecodecamp/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22

15px font size should be also applied to tasks desriptions ?
tasks description font size is by default equal to (1.5 x nomal text size) so i don't know if that should have the same font size as the other panes (15px)
below the difference between a 15px task description and (15 x 1.5)
15px_task_description
orginal_size1 5

@AbdelghaniTassi Excellent question. My inclination is to leave those descriptions the size that they are currently (we could specify a specific font size instead of using the 1.5x multiplier). What do you think about the current text size?

@QuincyLarson I think that the current text size is ok it's big and catchy for the small descriptions.
and as you said maybe we should specify a fixed size for the descriptions later so they don"t get bigger or smaller when we change the text size of other panes

@AbdelghaniTassi OK - we can leave the "slide" style challenge text the current size, but I think we should change it for all the other challenge views.

Regarding your suggestion of fixing the size of text, I'm not sure if I correctly understand what you're proposing. We still want for people who have visual impairments or bad eyesight to be able to make text larger, right?

@QuincyLarson Of course users will always be able to adjust text in the browser. what i meant by fixed text size is removing the 1.5 multiplier (maybe later).

I set text size to 15px, now it looks consistent.
font_size_consistency

@AbdelghaniTassi Great Work!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Ethan-Arrowood picture Ethan-Arrowood  路  56Comments

sadathanwar17 picture sadathanwar17  路  66Comments

QuincyLarson picture QuincyLarson  路  39Comments

mjanusauskas picture mjanusauskas  路  61Comments

mstellaluna picture mstellaluna  路  75Comments