Fightpandemics: [Desktop][Mobile] Feed | Post Creation | Visibility section

[galeza]

env: https://staging.fightpandemics.work/feed
Steps:

1. Open app and go to the Feed screen
2. Create a post as an individual
3. Screen opens and visibility is City.
   According to Figma design it should be Anyone:
   "The post will be visible to" Anyone | Forever
   https://app.zeplin.io/project/5ecaed1b2522d9280f1a4792/screen/5ed034d492a787b8225c0b08
   @TiagoaTavares are we going to change dropdown menu? In figma we have:
   
   

[TiagoaTavares]

• Change to Figma Design !

• Regarding to: "Anyone" | "Forever",
  we should change to: "Worldwide" | "Forever" by default

@galeza , one note: follow figma instead zeplin for MVP launch ... :)

[galeza]

Hi @TiagoaTavares ,

Ok. We will change to: "Worldwide" | "Forever" by default
and drop down menu like in figma.

Thank you!

[TiagoaTavares]

@galeza what's your forecast date to close this issue? :)
importante: We would set by default "Worldwide" | "month" !

[galeza]

Hi @TiagoaTavares
I don't know if we have resources to fix that. This issue is tagged: MVP - Release 1 so I think it should have priority.

[TiagoaTavares]

@idjevm ... It is "Worldwide" | "month" ! not "forever" !
--> https://github.com/FightPandemics/FightPandemics/issues/523#issuecomment-637720525

You should also change to Figma Design ! "For a month" instead of "month" and so on....
However this is not priority right now.... Try to solve issue related to Functionality instead of appearance...

[idjevm]

Ohhh @TiagoaTavares , I missed your last comment, guess I read too many times "Worldwide" | "forever". So should I just leave this open for now until the functionality has been updated? I am not familiar with this functionality yet, so not sure if changing it the defaults from "month" to "for a month" would affect something else.

I mean there is also another issue regarding to this, #605 when it comes to what the text says.

So so far based on what is the design, looks like it will say ->

The post is visible to (city, state, country, worldwide) (forever, month, year, day)...

If I just change the options then it will say ->

The post is visible to (in my city, in my state, in my country, worldwide) (forever, for a month, for a year, for a day).

Should I change the dropdown options and the The post is visible to text? or just the options?

[galeza]

Hi @idjevm

605 I asked @Yu-Alexa-Zhao about correct spelling and dropdown options + correct text (The post is visible not The post is visible in)

[TiagoaTavares]

For now, focus on another issue .. This doesn't influence the functionality...

[galeza]

Hi @TiagoaTavares @idjevm

Just a question. I checked data model and we don't have "state" option:

What do we insert into db while selecting this option? State = neighborhood?
Should I check it with data engineers?

[joshmorel]

Until we set up some kind of data model process again the source of truth is the master branch model files - e.g. https://github.com/FightPandemics/FightPandemics/blob/master/backend/lib/models/Location.js

We can decide about that post soft launch once we've stabilized a bit.

The two related PRs for this - we discussed in Slack with Manu - the designs weren't updated, can you ask someone?

https://github.com/FightPandemics/FightPandemics/pull/403
https://github.com/FightPandemics/FightPandemics/pull/407

I don't think we should include "In my neighborhood" as filter because many users might not have it and then the post may not reach enough people. It should be a discussion post MVP.

@galeza I think these two issues should be closed for now. I'll find the discussion in slack and message you.

[galeza]

Hi @joshmorel,

For now I'm closing #523 and #605

[galeza]

As stated in the PR #603 comments:
Default should be: City - Month

[joshmorel]

This is resolved right @galeza ?

[galeza]

Yes. I'm closing this issue