Fightpandemics: Shift+Enter to create a new line while commenting

[pemika-me]

Issue

(Staging) The user can't start a new line while writing a new comment. Both Enter or Shift+Enter are considered as sending the comment (The user is able to press Enter to begin the new line while editing the existing comment though.)

Please check the video in this post

Steps to reproduce

1. Access any post as a logged-in user, write a comment but not press the icon on the right to send it yet
2. Try press "Enter", you will see the comment is sent
3. Try writing a new comment and then press "Shift+Enter", the comment is sent anyway

Expected behavior

The user should be able to start a new line while commenting by using "Shift+Enter"

[joshmorel]

Thanks @pemika-me

Thought - maybe you should always need to hit button to post the comment? Looking at other sites it seems only with messaging that enter submits (with shift+enter adding new line).

But if we stick with enter->post then we do at least need shift+enter. Maybe even provide a note? in Slack:

[pemika-me]

Such a good point! Thank you @joshmorel for your great perspective.

Dear PM @doheekim93 @dhruvdpatel @ppagarawal
May you consider Josh's comment and give us a decision?

[pemika-me]

By the way, I think just require the user to hit the button to post a comment is the simplest one - as it's more reasonable for the user who accesses our website on Mobile web. (I have never pressed Shift :arrow_up: + Enter button to create a new line on my mobile keyboard) So both Desktop web and Mobile web can work with the same logic. (Enter to create a new line, and only send/post a comment when the send icon is hit)

[ppagarawal]

Typically, settings provide an option to decide what the enter should do. Here, I recommend that
Desktop: Enter must correspond to post action. Shift + Enter can be used for new line. (Think of UX here for using 1 device here instead of 2 devices to post)

Mobile: use the button to post. Pressing shift must toggle the send button to change to enter a new line.

@joshmorel @pemika-me

[AshBha243]

@pemika-me so finally what should be the result o pressing Enter and Shift+Enter?

[pemika-me]

@AshBha243 Please refer to @ppagarawal comment above.

Desktop: Enter must correspond to post action. Shift + Enter can be used for new line. (Think of UX here for using 1 device here instead of 2 devices to post)

@ppagarawal and would we add a footnote as per Josh's recommendation? (Similar to Slack's)

[pemika-me]

Hi team, I am the ticket's author and just decided to leave FP. Please contact PM or engineer lead in case you would need some info or review related to this ticket. Thanks. 😊

[joshmorel]

Thanks @pemika-me ! I'll take ownership of this one

[joshmorel]

Closing in favor of #1672