Fga: Script clicking too fast after order change

[saberkevin]

MAKE SURE YOU TESTED THE LATEST RELEASE.

See 'SAMSUNG.md' first, if you're a Samsung user.
Ignore notch is already activated

Describe the bug
So im grinding apocrypha raid, after order change the script is programmed to use second waver first skill, but because the order change is not finished yet , it click the first skill too soon and open the second servant info.

Screenshots
If applicable, add screenshots to help explain your problem.
If an error occurred, you can find the message by expanding the app's notification.
It is recommended that you atleast add one screenshot of FGO running on your device.

i think the description is enough. if need something for ss tell me.

Device Info (please fill atleast 'Device model'):

• Device model: [Samsung s9+]
• Screen size: [2220*1080]
• Android Version: [Android 10]
• RAM: [6 GB]

[saberkevin]

now im using the workaround by using other fake skill first like a2bcx11ba2bc, b in there is the fake skill to give time.

[StableSteady]

Yeah I have the same problem but with the True Ether MC. Any skill of MC causes a delay big enough that the next skill gets clicked before it's even there. Adding some fodder skills serves as a fix for now. An optional increase in the wait times would help.

[reconman]

You can also add a t2 to target an enemy instead of using a skill. One thing that was already changed in an unreleased version is that the delay between showing the master skills and clicking on them was increased, because it was regularly missing the NP charge skill.

[StableSteady]

That sounds like a better solution for now, I'll try that. Thanks.

[MathewSachin]

Hmm, the SelectSubMember function calls WaitForAnimationsToFinish

https://github.com/MathewSachin/Fate-Grand-Automata/blob/d1748279a6f2a112ae04d72b39b4312d45de04b8/FateGrandAutomata.Core/Modules/AutoSkill.cs#L122-L133

So, an additional wait of around ~1s~ 0.5s after detecting the Attack button should solve most problems with script clicking too soon after Order change or even skills.

https://github.com/MathewSachin/Fate-Grand-Automata/blob/d1748279a6f2a112ae04d72b39b4312d45de04b8/FateGrandAutomata.Core/Modules/AutoSkill.cs#L27-L35

I'll give this a try

[MathewSachin]

@saberkevin @consistentescape Does it take more than 15s for order change on your device? The script keeps checking if order change has completed around 3 times per second. After 15s it assumes that order change must have completed.
I'll increase the 15s timeout if that's the case. And, this wouldn't cause problems for faster devices.
Otherwise, I'll add an extra wait of half a second after detecting the Attack button which should allow for any remaining animations to finish.

[saberkevin]

no, i think it is under 10 second, because my device samsung s9+ is pretty fast

[MathewSachin]

Fine. I'll increase the other waiting time then and give you a build ASAP.

[MathewSachin]

@saberkevin Can you download the APK from this link: https://github.com/MathewSachin/Fate-Grand-Automata/actions/runs/88043362

It should be in a zipped folder. I've added an extra wait time of 1s after order change

[saberkevin]

alrite i will test it right now

[saberkevin]

i can confirm it is already working, my fake skill is clicked, thank you so much matthew :D

EDIT: i dont know if i should close the issue, but for me its already working so you can close mat :D

[MathewSachin]

Keep testing it a bit more and let me know later. I'll keep this issue open for a while.

[saberkevin]

okay so i already done 3 run (used SQ) , and all of it is working as expected 👌, i can't test more right now because my apple is all gone so i need to wait for my AP to refill.

[MathewSachin]

Thank you for testing!
I think it should work fine for others too since I didn't change much.
I'll close this issue and release v0.11.4 right away with the fix.