Eventing: Identify v1Beta1 API candidates and potential gaps

Created on 11 Sep 2019 · 18Comments · Source: knative/eventing

Problem
We need to figure out v1beta1 api surface for Knative Eventing. We could either start moving stable apis to v1beta1, or identify a minimum set of apis that make sense to promote together to v1beta1 and identify what is missing so that we can target to fill the gaps in v0.10 and promote to v1beta1 in v0.11

Exit Criteria

Identify minimal set of APIs that will be part of v1beta1 api surface
Identify what is missing for each construct and have issues
Target v1beta1 apis in or before v0.11

Epic kinfeature-request prioritimportant-soon proposa0.12

Source

akashrv

Most helpful comment

I will join. I like APIs.

n3wscott on 16 Oct 2019

😄1 👍1

All 18 comments

/milestone v0.10
/assign @matzew @vaikas-google

akashrv on 11 Sep 2019

I would add

identity what needs to be cleaned up/tuned in the minimal set of APIs

For instance

channel.spec.subscribable.subscribers -> channel.spec.subscribers (if possible)
subscription.spec.subscriber.ref -> channel.spec.subscriber

lionelvillard on 11 Sep 2019

/milestone v0.10.0

akashrv on 16 Sep 2019

documentation should be one a criteria as well

matzew on 17 Sep 2019

As we make those decisions maybe we could also document criteria and how we version APIs - and add to knative docs?

aslom on 17 Sep 2019

@akashrv I think I will start a document like this: https://docs.google.com/document/d/149LMccHt-gFEG52XoauVG2f-crjMk3-biu-pJPQGxCo/edit

I think that serving did well w/ their APIs, so I guess this is good for eventing too

matzew on 19 Sep 2019

Sounds good. If you could start a draft in eventing shared drive, we can
all then pitch in and add to it.

On Thu, Sep 19, 2019, 08:13 Matthias Wessendorf notifications@github.com
wrote:

@akashrv https://github.com/akashrv I think I will start a document
like this:
https://docs.google.com/document/d/149LMccHt-gFEG52XoauVG2f-crjMk3-biu-pJPQGxCo/edit

I think that serving did well w/ their APIs, so I guess this is good for
eventing too

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/knative/eventing/issues/1869?email_source=notifications&email_token=AKYQBFCB7L5XY66CUQDGGI3QKOJI5A5CNFSM4IVWWJZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7D2MJA#issuecomment-533177892,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYQBFADVVPAXTB5PA7CXC3QKOJI5ANCNFSM4IVWWJZQ
.

akashrv on 19 Sep 2019

👍1

related to #1976

akashrv on 15 Oct 2019

@matzew @vaikas-google Were you able to make any progress on this? Given we have just 2 weeks left for v10 milestone, shall we prioritize this work?

akashrv on 15 Oct 2019

Since we're still making API changes in v10 that haven't landed yet (destination), I think that rushing beta API version in the next 2 weeks probably isn't the best idea. If we're happy with the changes that are going in, perhaps a v1beta1 candidate for v11 is more realistic.

We added an item to the WG agenda for this week to discuss a task force to solidify this API. We did this for knative serving several months ago and that process worked well.

mikehelmick on 15 Oct 2019

We're still trying to distill what the changes are, once we figure them out, then it would be useful to understand in the context of the actual Deltas to see how likely things are to land or not.

vaikas on 15 Oct 2019

I agree. In the channel task force we spoke about parts of messaging APIs (e.g. Channel, Subscription, and IMC (as default impl)), but now there are coming changes to at least Subscription, or they are being discussed.

Between 0.10 and 0.11 we should see that we get a list, to be promoted by 0.12 or 0.13 ?

matzew on 15 Oct 2019

Mike, sign me up for that task force. I started a document, will share
later tonight or tomorrow

-M

On Tue 15. Oct 2019 at 19:32, Mike Helmick notifications@github.com wrote:

Since we're still making API changes in v10 that haven't landed yet
(destination), I think that rushing beta API version in the next 2 weeks
probably isn't the best idea. If we're happy with the changes that are
going in, perhaps a v1beta1 candidate for v11 is more realistic.

We added an item to the WG agenda for this week to discuss a task force to
solidify this API. We did this for knative serving several months ago and
that process worked well.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/knative/eventing/issues/1869?email_source=notifications&email_token=AABGPTSUOAWOYO4IWBY4WQ3QOX5AXA5CNFSM4IVWWJZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJS5JQ#issuecomment-542322342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGPTXQJGT3VUQALNYGN23QOX5AXANCNFSM4IVWWJZQ
.

>