Eventing: Use apis.HTTP() instead of apis.ParseURL() in the codebase

Created on 17 Jul 2020  路  8Comments  路  Source: knative/eventing

Problem
In the codebase, we use apis.ParseURL() in a lot of places. As @aliok suggested, https://github.com/knative/eventing/pull/3616#discussion_r456273469, apis.HTTP() is more convenient. We can use apis.HTTP() instead of apis.ParseURL() in the codebase

Persona:
Which persona is this feature for?

Exit Criteria
Use apis.HTTP() instead of apis.ParseURL() in the codebase

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

help wanted kincleanup kinfeature-request kingood-first-issue prioritimportant-longterm

All 8 comments

This is a good-first-issue

/good-first-issue

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Luckily not too many files ;)

pkg/apis/flows/v1/parallel_lifecycle_test.go
pkg/apis/flows/v1/sequence_lifecycle_test.go
pkg/apis/flows/v1beta1/parallel_lifecycle_test.go
pkg/apis/flows/v1beta1/sequence_lifecycle_test.go
pkg/apis/sources/v1alpha1/apiserver_conversion_test.go
pkg/apis/sources/v1alpha1/apiserver_lifecycle.go
pkg/apis/sources/v1alpha1/ping_conversion_test.go
pkg/apis/sources/v1alpha1/ping_lifecycle_test.go
pkg/apis/sources/v1alpha1/sinkbinding_conversion_test.go
pkg/apis/sources/v1alpha2/apiserver_conversion_test.go
pkg/apis/sources/v1alpha2/apiserver_lifecycle_test.go
pkg/apis/sources/v1alpha2/container_conversion_test.go
pkg/apis/sources/v1alpha2/ping_lifecycle_test.go
pkg/apis/sources/v1beta1/apiserver_lifecycle_test.go
pkg/inmemorychannel/message_dispatcher_test.go
pkg/mtbroker/filter/filter_handler_test.go
pkg/reconciler/apiserversource/apiserversource_test.go
pkg/reconciler/mtbroker/broker_test.go
pkg/reconciler/pingsource/pingsource_test.go
pkg/reconciler/pingsource/resources/receive_adapter_test.go
pkg/reconciler/source/duck/duck.go
pkg/reconciler/source/duck/duck_test.go
pkg/reconciler/testing/v1/trigger.go
pkg/reconciler/testing/v1beta1/trigger.go
test/conformance/helpers/channel_spec_test_helper.go
test/lib/resources/eventing.go

I can do that could you assign me to it.

@skonto You can comment with /assign

/assign @skonto

updated list:

$grep -Ril "apis.ParseURL" ./ | wc -l
29
$ grep -Ril "apis.ParseURL" ./ | sort
./pkg/apis/flows/v1beta1/parallel_lifecycle_test.go
./pkg/apis/flows/v1beta1/sequence_lifecycle_test.go
./pkg/apis/flows/v1/parallel_lifecycle_test.go
./pkg/apis/flows/v1/sequence_lifecycle_test.go
./pkg/apis/sources/v1alpha1/apiserver_conversion_test.go
./pkg/apis/sources/v1alpha1/apiserver_lifecycle.go
./pkg/apis/sources/v1alpha1/ping_conversion_test.go
./pkg/apis/sources/v1alpha1/ping_lifecycle_test.go
./pkg/apis/sources/v1alpha1/sinkbinding_conversion_test.go
./pkg/apis/sources/v1alpha2/apiserver_conversion_test.go
./pkg/apis/sources/v1alpha2/apiserver_lifecycle_test.go
./pkg/apis/sources/v1alpha2/container_conversion_test.go
./pkg/apis/sources/v1alpha2/ping_conversion_test.go
./pkg/apis/sources/v1alpha2/ping_lifecycle_test.go
./pkg/apis/sources/v1beta1/apiserver_lifecycle_test.go
./pkg/apis/sources/v1beta1/ping_lifecycle_test.go
./pkg/inmemorychannel/message_dispatcher_test.go
./pkg/mtbroker/filter/filter_handler_test.go
./pkg/reconciler/apiserversource/apiserversource_test.go
./pkg/reconciler/mtbroker/broker_test.go
./pkg/reconciler/mtbroker/trigger/trigger_test.go
./pkg/reconciler/pingsource/pingsource_test.go
./pkg/reconciler/pingsource/resources/receive_adapter_test.go
./pkg/reconciler/source/duck/duck.go
./pkg/reconciler/source/duck/duck_test.go
./pkg/reconciler/testing/v1beta1/trigger.go
./pkg/reconciler/testing/v1/trigger.go
./test/conformance/helpers/channel_spec_test_helper.go
./test/lib/resources/eventing.go
Was this page helpful?
0 / 5 - 0 ratings